Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inventory threshold rule preview description #3941

Merged
merged 2 commits into from
May 30, 2024

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented May 29, 2024

@dedemorton dedemorton self-assigned this May 29, 2024
@dedemorton dedemorton requested a review from a team as a code owner May 29, 2024 19:51
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented May 29, 2024

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 29, 2024
@dedemorton dedemorton added backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify backport-7.17 Automated backport with mergify backport-7.16 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels May 29, 2024
@dedemorton
Copy link
Contributor Author

Not backporting all the way to 7.13 because our automation (and processes) don't support that. I will try to get it into 7.16.

@dedemorton dedemorton requested review from a team and maryam-saeidi May 29, 2024 21:58
maryam-saeidi
maryam-saeidi previously approved these changes May 30, 2024
Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, added a suggestion.

docs/en/observability/inventory-threshold-alert.asciidoc Outdated Show resolved Hide resolved
@dedemorton dedemorton merged commit 17d170b into elastic:main May 30, 2024
3 checks passed
@dedemorton dedemorton deleted the issue#3880 branch May 30, 2024 19:37
mergify bot pushed a commit that referenced this pull request May 30, 2024
* Fix inventory threshold rule preview description

* Apply changes from review

(cherry picked from commit 17d170b)

# Conflicts:
#	docs/en/observability/images/inventory-alert.png
#	docs/en/observability/inventory-threshold-alert.asciidoc
mergify bot pushed a commit that referenced this pull request May 30, 2024
* Fix inventory threshold rule preview description

* Apply changes from review

(cherry picked from commit 17d170b)

# Conflicts:
#	docs/en/observability/images/inventory-alert.png
#	docs/en/observability/inventory-threshold-alert.asciidoc
mergify bot pushed a commit that referenced this pull request May 30, 2024
* Fix inventory threshold rule preview description

* Apply changes from review

(cherry picked from commit 17d170b)
mergify bot pushed a commit that referenced this pull request May 30, 2024
* Fix inventory threshold rule preview description

* Apply changes from review

(cherry picked from commit 17d170b)
dedemorton added a commit that referenced this pull request May 30, 2024
* Fix inventory threshold rule preview description

* Apply changes from review

(cherry picked from commit 17d170b)

Co-authored-by: DeDe Morton <[email protected]>
dedemorton added a commit that referenced this pull request May 30, 2024
* Fix inventory threshold rule preview description

* Apply changes from review

(cherry picked from commit 17d170b)

Co-authored-by: DeDe Morton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.16 Automated backport with mergify backport-7.17 Automated backport with mergify backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Inventory threshold rule preview section
3 participants