Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdx → asciidoc] Add AsciiDoc serverless files #4480

Merged
merged 16 commits into from
Nov 5, 2024
Merged

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Nov 4, 2024

Description

Adds AsciiDoc serverless files.

I did a full review where I looked at:

  • The diff between the MDX and AsciiDoc file for each page and confirmed that the only changes were to the syntax.
  • The rendered result of the both the MDX version and AsciiDoc version of each page side-by-side and confirmed that they result in the same structure.

This PR adds AsciiDoc files and images to replace DocIcon. A few MDX files are edited where the MDX syntax was incorrect. MDX files will be deleted in a follow-up PR.

You can see the result in this preview: https://docs_bk_3096.docs-preview.app.elstc.co/guide/en/serverless/current/what-is-observability-serverless.html

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Related to elastic/docs#3096

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@colleenmcginnis colleenmcginnis added ci:doc-build backport-main Automated backport with mergify labels Nov 4, 2024
@colleenmcginnis colleenmcginnis self-assigned this Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented Nov 4, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@colleenmcginnis colleenmcginnis added backport-skip Skip notification from the automated backport with mergify and removed backport-main Automated backport with mergify labels Nov 4, 2024
@colleenmcginnis colleenmcginnis marked this pull request as ready for review November 5, 2024 16:03
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner November 5, 2024 16:03
@colleenmcginnis colleenmcginnis merged commit 93fdf1f into main Nov 5, 2024
9 checks passed
@colleenmcginnis colleenmcginnis deleted the mdx-to-asciidoc branch November 5, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants