Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS Firehose quickstart] Port 4433 to serverless docs #4545

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Nov 18, 2024

Description

Port #4433 to serverless docs.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4434

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@alaudazzi alaudazzi added the backport-skip Skip notification from the automated backport with mergify label Nov 18, 2024
@alaudazzi alaudazzi self-assigned this Nov 18, 2024
@alaudazzi alaudazzi requested a review from a team as a code owner November 18, 2024 11:35
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

mdbirnstiehl
mdbirnstiehl previously approved these changes Nov 18, 2024
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

eedugon
eedugon previously approved these changes Nov 18, 2024
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've added a comment about the pre-requisites section, just in case it's useful.

@alaudazzi alaudazzi dismissed stale reviews from eedugon and mdbirnstiehl via 5bd9711 November 19, 2024 06:08
@alaudazzi
Copy link
Contributor Author

@mykolaharmash
Can you have a look and confirm the text is OK for serverless?

mykolaharmash
mykolaharmash previously approved these changes Nov 20, 2024
Copy link

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you ✨

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alaudazzi alaudazzi merged commit 072c7ef into elastic:main Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Port #4433 to serverless docs
4 participants