Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update explore-logs.asciidoc missing permissions #4566

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

toby-sutor
Copy link
Contributor

The Kibana permission Observability --> Logs (read) is also required as per internal tests on 8.16.1.

Description

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

The Kibana permission Observability --> Logs (read) is also required as per internal tests on 8.16.1.
@toby-sutor toby-sutor added docs Improvements or additions to documentation Team:Docs Label for the Observability docs team labels Nov 22, 2024
@toby-sutor toby-sutor requested a review from a team as a code owner November 22, 2024 10:23
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Nov 22, 2024

This pull request does not have a backport label. Could you fix it @toby-sutor? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 22, 2024
@mdbirnstiehl mdbirnstiehl added backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Nov 22, 2024
yngrdyn
yngrdyn previously approved these changes Nov 22, 2024
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@mdbirnstiehl mdbirnstiehl added the backport-8.17 Automated backport with mergify label Nov 22, 2024
@mdbirnstiehl mdbirnstiehl merged commit fef5caa into main Nov 22, 2024
6 checks passed
@mdbirnstiehl mdbirnstiehl deleted the toby-sutor-patch-1 branch November 22, 2024 19:19
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
mdbirnstiehl pushed a commit that referenced this pull request Nov 22, 2024
mdbirnstiehl pushed a commit that referenced this pull request Nov 22, 2024
mdbirnstiehl pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify docs Improvements or additions to documentation needs-writer-review Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants