Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #4588

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Patch 1 #4588

merged 1 commit into from
Dec 12, 2024

Conversation

JulienOrain
Copy link
Contributor

Description

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@JulienOrain JulienOrain requested a review from a team as a code owner November 27, 2024 13:34
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Nov 27, 2024

This pull request is now in conflict. Could you fix it @JulienOrain? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b patch-1 upstream/patch-1
git merge upstream/main
git push upstream patch-1

Copy link
Contributor

mergify bot commented Nov 27, 2024

This pull request does not have a backport label. Could you fix it @JulienOrain? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 27, 2024
@dedemorton
Copy link
Contributor

I think you must have created this PR against the wrong branch because there are too many changed files. Please submit a PR that contains your changes only. Thanks!

@JulienOrain JulienOrain changed the base branch from main to 8.16 November 27, 2024 19:26
@JulienOrain
Copy link
Contributor Author

yes, sorry !
I changed for elastic:8.16

@dedemorton dedemorton added backport-main Automated backport with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Nov 27, 2024
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton
Copy link
Contributor

run docs-build

@dedemorton dedemorton merged commit 008f24a into elastic:8.16 Dec 12, 2024
20 checks passed
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
(cherry picked from commit 008f24a)
@mergify mergify bot mentioned this pull request Dec 12, 2024
10 tasks
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
(cherry picked from commit 008f24a)
@mergify mergify bot mentioned this pull request Dec 12, 2024
10 tasks
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
(cherry picked from commit 008f24a)
@mergify mergify bot mentioned this pull request Dec 12, 2024
10 tasks
dedemorton pushed a commit that referenced this pull request Dec 12, 2024
(cherry picked from commit 008f24a)

Co-authored-by: Julien Orain <[email protected]>
dedemorton pushed a commit that referenced this pull request Dec 12, 2024
(cherry picked from commit 008f24a)

Co-authored-by: Julien Orain <[email protected]>
dedemorton pushed a commit that referenced this pull request Dec 12, 2024
(cherry picked from commit 008f24a)

Co-authored-by: Julien Orain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-main Automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants