-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port PR 4488 to Serverless - adding k8s-otel quickstart guide #4589
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request does not have a backport label. Could you fix it @eedugon? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor edits to make this consistent with #4582.
Also make sure that you update the getting started overview here to include the link to the new quickstart: https://observability-docs_bk_4582.docs-preview.app.elstc.co/guide/en/observability/master/observability-get-started.html#quickstarts-overview
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
Good catch @dedemorton , I had forgotten it even for the stateful docs, and I've seen that @alaudazzi had also forgotten it when adding the firehose quickstart in stateful. So I've updated the file |
As now this PR touches a |
Have we agreed to remove the images in the |
No, we haven't, we've decided to keep them as we can always remove them instead of updating if they end up being outdated too fast. Take a look at @dedemorton's comment #4582 (comment) Also PR 4582 is already merged and the updated screenshot in firehose quickstart is live :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few minor editing suggestions, otherwise LGTM.
Co-authored-by: Arianna Laudazzi <[email protected]>
Co-authored-by: Arianna Laudazzi <[email protected]>
This requires a final review as after changing a new file the merge is not possible (cc: @dedemorton ) :) |
* k8s-otel quickstart added to serverless * minor fixes in stateful (cherry picked from commit 58c98f8) # Conflicts: # docs/en/serverless/index.asciidoc # docs/en/serverless/observability-get-started.asciidoc
* k8s-otel quickstart added to serverless * minor fixes in stateful (cherry picked from commit 58c98f8) # Conflicts: # docs/en/serverless/index.asciidoc # docs/en/serverless/observability-get-started.asciidoc
* k8s-otel quickstart added to serverless * minor fixes in stateful (cherry picked from commit 58c98f8) # Conflicts: # docs/en/serverless/index.asciidoc # docs/en/serverless/observability-get-started.asciidoc
…uickstart guide (#4607) * Port PR 4488 to Serverless - adding k8s-otel quickstart guide (#4589) * k8s-otel quickstart added to serverless * minor fixes in stateful (cherry picked from commit 58c98f8) # Conflicts: # docs/en/serverless/index.asciidoc # docs/en/serverless/observability-get-started.asciidoc * Delete docs/en/serverless directory --------- Co-authored-by: Edu González de la Herrán <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…uickstart guide (#4606) * Port PR 4488 to Serverless - adding k8s-otel quickstart guide (#4589) * k8s-otel quickstart added to serverless * minor fixes in stateful (cherry picked from commit 58c98f8) # Conflicts: # docs/en/serverless/index.asciidoc # docs/en/serverless/observability-get-started.asciidoc * Delete docs/en/serverless directory --------- Co-authored-by: Edu González de la Herrán <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ickstart guide (#4605) * Port PR 4488 to Serverless - adding k8s-otel quickstart guide (#4589) * k8s-otel quickstart added to serverless * minor fixes in stateful (cherry picked from commit 58c98f8) # Conflicts: # docs/en/serverless/index.asciidoc # docs/en/serverless/observability-get-started.asciidoc * Delete docs/en/serverless directory --------- Co-authored-by: Edu González de la Herrán <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Porting #4488 to Serveless
Added a fix in stateful get-started main doc on the quickstarts section (missing links to the recently created quickstart guides).
Documentation sets edited in this PR
Check all that apply.
docs/en/observability/*
)docs/en/serverless/*
)docs/en/integrations/*
)Related issue
Closes #4535
Checklist
Follow-up tasks
Select one.