Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about quickstart to logs stream docs #4628

Merged

Conversation

mdbirnstiehl
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl commented Dec 4, 2024

Description

This PR clarifies that the Logs stream docs show how to manually configure a standalone agent, and users also have the option of using the automatic log detection in the quickstart.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Checklist

  • Product/Engineering Review
  • Writer Review

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)

@mdbirnstiehl mdbirnstiehl added needs-writer-review backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Dec 4, 2024
@mdbirnstiehl mdbirnstiehl self-assigned this Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mdbirnstiehl mdbirnstiehl marked this pull request as ready for review December 4, 2024 21:41
@mdbirnstiehl mdbirnstiehl requested a review from a team as a code owner December 4, 2024 21:41
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo. Otherwise looks good.

docs/en/observability/logs-stream.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/logs-stream.asciidoc Show resolved Hide resolved
@mdbirnstiehl mdbirnstiehl merged commit efe94d9 into elastic:main Dec 5, 2024
3 checks passed
@mdbirnstiehl mdbirnstiehl deleted the add-quickstart-info-to-logs-stream branch December 5, 2024 14:25
mergify bot pushed a commit that referenced this pull request Dec 5, 2024
mergify bot pushed a commit that referenced this pull request Dec 5, 2024
mergify bot pushed a commit that referenced this pull request Dec 5, 2024
mdbirnstiehl added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit efe94d9)

Co-authored-by: Mike Birnstiehl <[email protected]>
mdbirnstiehl added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit efe94d9)

Co-authored-by: Mike Birnstiehl <[email protected]>
mdbirnstiehl added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit efe94d9)

Co-authored-by: Mike Birnstiehl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants