Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #4633) Serverless - crop images that show old navigation #4638

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 5, 2024

Description

This PR crops out old/misleading nav.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

#4539

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

This is an automatic backport of pull request #4633 done by [Mergify](https://mergify.com).

(cherry picked from commit 1899119)

# Conflicts:
#	docs/en/serverless/images/cases.png
#	docs/en/serverless/images/entity-detailed-view.png
#	docs/en/serverless/images/inventory-catalog.png
#	docs/en/serverless/images/observability-cases-settings.png
#	docs/en/serverless/images/quickstart-k8s-otel-dashboard.png
#	docs/en/serverless/images/quickstart-k8s-overview.png
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Dec 5, 2024
@mergify mergify bot requested a review from a team as a code owner December 5, 2024 18:32
Copy link
Contributor Author

mergify bot commented Dec 5, 2024

Cherry-pick of 1899119 has failed:

On branch mergify/bp/8.16/pr-4633
Your branch is up to date with 'origin/8.16'.

You are currently cherry-picking commit 18991194.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/en/observability/images/quickstart-k8s-otel-dashboard.png

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/en/serverless/images/cases.png
	deleted by us:   docs/en/serverless/images/entity-detailed-view.png
	deleted by us:   docs/en/serverless/images/inventory-catalog.png
	deleted by us:   docs/en/serverless/images/observability-cases-settings.png
	deleted by us:   docs/en/serverless/images/quickstart-k8s-otel-dashboard.png
	deleted by us:   docs/en/serverless/images/quickstart-k8s-overview.png

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

github-actions bot commented Dec 5, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor Author

mergify bot commented Dec 9, 2024

This pull request has not been merged yet. Could you please review and merge it @alaudazzi? 🙏

@colleenmcginnis colleenmcginnis enabled auto-merge (squash) December 13, 2024 17:01
@colleenmcginnis colleenmcginnis removed the conflicts There is a conflict in the backported pull request label Dec 13, 2024
@colleenmcginnis colleenmcginnis merged commit 2121c23 into 8.16 Dec 13, 2024
3 checks passed
@colleenmcginnis colleenmcginnis deleted the mergify/bp/8.16/pr-4633 branch December 13, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants