Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #4644) cleanup(apm): remove old rum deprecations #4675

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 12, 2024

Description

deprecated rum config options have been removed in 8.0 so they no longer apply.
remove the deprecated options from docs

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes elastic/apm-server#14126

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

This is an automatic backport of pull request #4644 done by [Mergify](https://mergify.com).

deprecated rum config options have been removed in 8.0
so they no longer apply.
remove the deprecated options from docs

(cherry picked from commit 944662f)

# Conflicts:
#	docs/en/observability/apm/configure/rum.asciidoc
@mergify mergify bot requested a review from a team as a code owner December 12, 2024 14:59
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Dec 12, 2024
Copy link
Contributor Author

mergify bot commented Dec 12, 2024

Cherry-pick of 944662f has failed:

On branch mergify/bp/8.15/pr-4644
Your branch is up to date with 'origin/8.15'.

You are currently cherry-picking commit 944662f0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/en/observability/apm/configure/rum.asciidoc

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis removed the conflicts There is a conflict in the backported pull request label Dec 12, 2024
@colleenmcginnis colleenmcginnis enabled auto-merge (squash) December 12, 2024 15:59
@colleenmcginnis colleenmcginnis merged commit 780b919 into 8.15 Dec 12, 2024
4 checks passed
@colleenmcginnis colleenmcginnis deleted the mergify/bp/8.15/pr-4644 branch December 12, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants