-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apm] Update APM decision tree diagram #4713
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
The explanations look awesome in my opinion! I like it a lot. Quick comment about one of them, not very important:
Considering an edge machine might (or typically) host multiple applications that could be instrumented, I would state it with something like:
Anyway your proposal looks good also. The only pending issue I see in the diagram is this one: I would suggest to find the way to state that the What I'd like to avoid is users thinking that they must deploy Fleet Server together with APM Server always. (UPDATE: ops... I think this is covered in #4714 ) -> sorry for the noise! |
When the initial flowchart was created, one goal was to encourage folks who wanted to run APM Server on the edge to use Fleet-managed APM. That's not a goal anymore. I like the clarifications that Edu suggested. I also agree that this isn't meant to be a complete reference of all possibilities. Can we just directly say that? Something like:
|
* update apm decision tree diagram * add pro to fleet-managed list * address feedback from @eedugon * address feedback from @bmorelli25 (cherry picked from commit f1ce0e1)
* update apm decision tree diagram * add pro to fleet-managed list * address feedback from @eedugon * address feedback from @bmorelli25 (cherry picked from commit f1ce0e1)
* update apm decision tree diagram * add pro to fleet-managed list * address feedback from @eedugon * address feedback from @bmorelli25 (cherry picked from commit f1ce0e1)
* update apm decision tree diagram * add pro to fleet-managed list * address feedback from @eedugon * address feedback from @bmorelli25 (cherry picked from commit f1ce0e1) Co-authored-by: Colleen McGinnis <[email protected]>
* update apm decision tree diagram * add pro to fleet-managed list * address feedback from @eedugon * address feedback from @bmorelli25 (cherry picked from commit f1ce0e1) Co-authored-by: Colleen McGinnis <[email protected]>
* update apm decision tree diagram * add pro to fleet-managed list * address feedback from @eedugon * address feedback from @bmorelli25 (cherry picked from commit f1ce0e1) Co-authored-by: Colleen McGinnis <[email protected]>
Description
Updates the APM decision tree to address feedback from @eedugon including:
Note: In #4669 @eedugon mentioned that where the user is running APM Server (edge machine vs centrally) doesn't technically determine whether they must use Fleet-managed or APM Server binary. However, the goal of this section is to help a new user make a decision based on several factors not to be a complete reference of all implementations that are or aren't possible with Elastic APM. Is there anything we can change about the intro to the "Help me decide" section to make that clearer? @bmorelli25 any thoughts here?
Documentation sets edited in this PR
Check all that apply.
docs/en/observability/*
)docs/en/serverless/*
)docs/en/integrations/*
)Related issue
Closes #4669
Checklist
Follow-up tasks
Select one.