Fix/pitch shift #166
Draft
Fix/pitch shift #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't quite ready. Checked the "fun" parameter, and it is quite fun when tranpsosing up, but when transposing down it just adds a bunch of noise. So we probably need to flip the direction the modulation happens in when transposing below 0 It also does nothing when set to original pitch, |
…added some auto-recalc for transposition at/near zero.
|
This would also fix #201 |
|
@stephenhensley is there more work to be done for this? I wanted to open a PR to templatize or parameterize the buffer size but want it based off of this PR. I have run this PR a decent amount and it seems pretty solid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should end up fixing #162
The negative transposition was almost 2x the ratio that it was supposed to. So that none of the semitones were accurate when set below 0. This has been fixed.
Making the phasor accept negative frequency let's us remove any of the weird "is it going up or down" logic, and just have the phasor flip when the ratio is derived from a negative transposition.
This does remove the pre-generated lookup for the semitones. We can replace it with a more robust lut at some point to get this to be a bit more efficient.
Also moved the one global define into the class as a member constexpr
And added a secondary argument (defaulting to false) to lock transpositions to semitones.