Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FreeBSD support #1163

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add FreeBSD support #1163

merged 1 commit into from
Aug 9, 2023

Conversation

lwhsu
Copy link
Contributor

@lwhsu lwhsu commented Aug 8, 2023 •
edited by github-actions bot
Loading

Checklist

  • Ensure your code works with manual testing
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

We've been using this in https://github.com/tagattie/FreeBSD-Electron/tree/master/net-im/element-desktop and running since 1.11.25.

Here's what your changelog entry will look like:

✨ Features

@lwhsu lwhsu requested a review from a team as a code owner August 8, 2023 18:49
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 8, 2023
@lwhsu
Copy link
Contributor Author

lwhsu commented Aug 8, 2023

@tagattie

@SimonBrandner SimonBrandner requested a review from a team August 9, 2023 08:48
@SimonBrandner
Copy link
Contributor

This is going to need a product reviev

@t3chguy
Copy link
Member

t3chguy commented Aug 9, 2023

@SimonBrandner no it isn't, this is merely adding the capability for a third party to produce freebsd builds including seshat & keytar, nothing more

@t3chguy t3chguy removed the request for review from a team August 9, 2023 09:10
t3chguy
t3chguy approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for contributing this upstream

@t3chguy t3chguy merged commit a0f9294 into element-hq:develop Aug 9, 2023
26 of 27 checks passed
@SimonBrandner
Copy link
Contributor

Good point

@lwhsu lwhsu deleted the freebsd branch August 30, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

@SimonBrandner SimonBrandner Awaiting requested review from SimonBrandner SimonBrandner is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lwhsu @SimonBrandner @t3chguy @tagattie