Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated no drag zones #1193

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 31, 2023

Follows up on #1136 after new development in that area...

Checklist

  • Ensure your code works with manual testing
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Updated no drag zones (#1193).

@Johennes
Copy link
Contributor

Johennes commented Sep 4, 2023

@t3chguy I'm trying to see which of the remaining room header PRs we could reasonably land this week. You have recently set up the no-drag handling. Could you help review this PR?

@Johennes
Copy link
Contributor

Johennes commented Sep 5, 2023

Tested the macOS build and this seems to work fine. It's worth noting that there is less draggable space now than before because the topic fills the remaining width and is not draggable. This might need further thought in future.

@Johennes Johennes self-requested a review September 5, 2023 10:30
@Johennes Johennes merged commit 2c62efa into develop Sep 5, 2023
24 checks passed
@Johennes Johennes deleted the germain-gg/room-header-no-drag-zone branch September 5, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants