Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update localization lookup #34

Merged
merged 5 commits into from
Apr 15, 2024
Merged

fix: update localization lookup #34

merged 5 commits into from
Apr 15, 2024

Conversation

GeekyEggo
Copy link
Member

  • Localizations lookup now uses the Localization node as the prefix of a localization key.
  • If a translation does not exist, the key is now returned instead of undefined.

@GeekyEggo GeekyEggo requested a review from ChekTek April 12, 2024 13:08
ChekTek
ChekTek previously approved these changes Apr 14, 2024
View reviewed changes
@GeekyEggo GeekyEggo merged commit 4daecce into main Apr 15, 2024
4 checks passed
@GeekyEggo GeekyEggo deleted the localizations branch April 15, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChekTek ChekTek ChekTek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeekyEggo @ChekTek