-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix scroll issue in email thread #206
base: main
Are you sure you want to change the base?
Conversation
@PradhyumArora is attempting to deploy a commit to the Inbox Zero Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes made to the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/components/email-list/EmailPanel.tsx (1 hunks)
Additional comments not posted (1)
apps/web/components/email-list/EmailPanel.tsx (1)
184-184
: LGTM! Verify the fix in the UI.The addition of the
relative
class to thediv
element is a common technique to provide a positioning context for absolutely positioned child elements. This change should resolve the issue of unexpected whitespace and vertical scrollbars caused by tooltips within list items.However, ensure that the fix resolves the issue in the UI as expected.
Hi Elie, is there any change you want me to make or can this be merged smoothly? |
The tooltip in the
Adding relative position fixed it and now it works as expected.
fixes Shouldn't show scrollbar/empty space when reading a thread #205
Summary by CodeRabbit
Bug Fixes
Style