Fix #179 - Replace autocomplete for contacts #220
Conversation
- Modal is now big and fully responsive - Simplified the styling - changed the design of the "To" autocomplete to the desired one
|
@madhav-relish is attempting to deploy a commit to the Inbox Zero Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes primarily involve enhancements to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/web/app/(app)/compose/ComposeEmailForm.tsx (4 hunks)
- apps/web/components/Modal.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- apps/web/components/Modal.tsx
Additional comments not posted (5)
apps/web/app/(app)/compose/ComposeEmailForm.tsx (5)
3-8: LGTM!The import statements are correctly updated to include
ComboboxInput.The code changes are approved.
174-174: LGTM!The JSX structure changes for the
Comboboxcomponent are correctly implemented.The code changes are approved.
179-179: LGTM!The styling changes for the
Badgecomponent are correctly implemented.The code changes are approved.
193-195: LGTM!The introduction of the
ComboboxInputcomponent and its styling changes are correctly implemented.The code changes are approved.
303-303: LGTM!The class name update for the
EditorContentcomponent is correctly implemented.The code changes are approved.
| {selectedEmailAddressses.map((emailAddress) => ( | ||
| <Badge | ||
| key={emailAddress} | ||
| variant="outline" | ||
| className="mr-1.5" | ||
| className="h-8 rounded-md border-primary bg-primary text-white" |
There was a problem hiding this comment.
avoid primary and just go with the color. we don't use bg-primary anywhere in the codebase
| @@ -61,25 +61,24 @@ export function Modal(props: ModalProps) { | |||
| leave="ease-in duration-200" | |||
| leaveFrom="opacity-100 scale-100" | |||
| leaveTo="opacity-0 scale-95" | |||
| className={clsx( | |||
There was a problem hiding this comment.
modals everywhere else on the site still work fine after this change?
There was a problem hiding this comment.
Yeah, the only place where layout was not looking good was the VideoDemo.tsx modal (Demo video on the landing page) which is now fixed in the latest PR #201
Fix #179