Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug documentation edits #1161

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Conversation

bradhanks
Copy link
Contributor

Removed passive voice. Made some edits for clarity, readability; there was some inconsistentcy about when Plug was being capitalized.

lib/plug.ex Outdated
While `Plug.Builder` is designed to operate at compile-time, the `run` function
=======
While Plug.Builder is designed to operate at compile-time, the `run` function
>>>>>>> origin/plug_doc_edits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict. :)

@josevalim
Copy link
Member

Ping, can you please address the merge conflicts? Then I will gladly do another pass. Thanks!

@bradhanks
Copy link
Contributor Author

Ok I fixed the merge conflict. Thanks for your patience!

@josevalim josevalim merged commit e6f440b into elixir-plug:main Nov 16, 2023
2 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@bradhanks bradhanks deleted the plug_doc_edits branch December 23, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants