Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added StorageBehavior #133

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

OkinawaNet
Copy link

This pull request introduces the StorageBehavior module, which defines a behavior for storage backends in our application. The StorageBehavior includes three key callbacks: put, url, and delete. These callbacks are designed to standardize the interface for different storage implementations, allowing for greater flexibility and modularity in our codebase.

@OkinawaNet OkinawaNet force-pushed the storage_behavior branch 2 times, most recently from 22ed35a to 281a0ed Compare November 27, 2024 18:41
@OkinawaNet OkinawaNet force-pushed the storage_behavior branch 2 times, most recently from 94a1b8a to db814fc Compare November 27, 2024 19:14
Copy link
Member

@achempion achempion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks 👍 I'll merge it once CI is passing

@OkinawaNet
Copy link
Author

Looks great, thanks 👍 I'll merge it once CI is passing

Thanks! I've fixed CI errors.

@achempion achempion merged commit 71ce749 into elixir-waffle:master Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants