Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support to Goth >= 1.3 #2

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

ulissesalmeida
Copy link
Collaborator

The PR is a suggestion in how we could offically support Goth >= 1.3.

Basically, the Goth >= 1.3, the user's app need to start a process that
will fetch and own a token. To be fair, this library doesn't need to do
much to transit to Goth 1.3 thanks to the Token Fetcher behaviour.

So this PR make changes to make the library use Goth >= 1.3 as
an example, update the Readme, and now requires the library to
suppliy a token fetcher module.

@petermueller
Copy link
Collaborator

when you get a chance, could you rebase? I mainly just wanna confirm all the tests work w/ the different versions. I don't see why they wouldn't though?

@fastjames
Copy link
Contributor

Hi all, I noticed in the failing test (OTP 24) that for some reason the jose dependency was still at 1.10.1. I think that's the source of the calls to poly1305 that were removed in OTP24. I pulled the branch locally and ran

mix deps.update jose

and that updated the dep to 1.11.6. The update appeared to clear those errors.

@fastjames
Copy link
Contributor

Hi all, I noticed in the failing test (OTP 24) that for some reason the jose dependency was still at 1.10.1. I think that's the source of the calls to poly1305 that were removed in OTP24. I pulled the branch locally and ran

mix deps.update jose

and that updated the dep to 1.11.6. The update appeared to clear those errors.

The library update appears to work standalone, so I opened a separate PR for it: #6 .

@petermueller petermueller mentioned this pull request Feb 21, 2024
test/test_helper.exs Outdated Show resolved Hide resolved
@ulissesalmeida ulissesalmeida force-pushed the ua-goth-upgrade branch 4 times, most recently from 122ad06 to b8aa110 Compare February 26, 2024 11:33
The PR is a suggestion in how we could offically support Goth >= 1.3.

Basically, the Goth >= 1.3, the user's app need to start a process that
will fetch and own a token. To be fair, this library doesn't need to do
much to transit to Goth 1.3 thanks to the Token Fetcher behaviour.

So this PR make changes to make the library use Goth >= 1.3 as
an example, update the Readme, and now requires the library to
suppliy a token fetcher module.
@petermueller petermueller merged commit ecfe374 into main Apr 5, 2024
5 checks passed
@petermueller petermueller deleted the ua-goth-upgrade branch April 5, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants