Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: merging of mol2 files w/ atom deletion & bond formation #273

Merged
merged 9 commits into from
Nov 8, 2023

Conversation

eljost
Copy link
Owner

@eljost eljost commented Oct 25, 2023

No description provided.

pysisyphus/drivers/merge_mol2.py Dismissed Show dismissed Hide dismissed
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #273 (5998377) into master (3b8db75) will decrease coverage by 0.34%.
Report is 4 commits behind head on master.
The diff coverage is 9.90%.

❗ Current head 5998377 differs from pull request most recent head 823e7b5. Consider uploading reports for the commit 823e7b5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   61.97%   61.64%   -0.34%     
==========================================
  Files         281      282       +1     
  Lines       29219    29394     +175     
==========================================
+ Hits        18108    18119      +11     
- Misses      11111    11275     +164     
Flag Coverage Δ
unittests 61.64% <9.90%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pysisyphus/calculators/HardSphere.py 100.00% <100.00%> (ø)
pysisyphus/helpers_pure.py 68.65% <100.00%> (ø)
pysisyphus/io/mol2.py 89.36% <61.53%> (+1.26%) ⬆️
pysisyphus/drivers/merge.py 13.33% <31.81%> (+2.16%) ⬆️
pysisyphus/drivers/precon_pos_rot.py 91.08% <7.14%> (-6.88%) ⬇️
pysisyphus/drivers/merge_mol2.py 0.00% <0.00%> (ø)

Johannes Steinmetzer added 8 commits October 25, 2023 15:18
mod: switch to mmff94 as uff just crashes :)
add: typing & docstrings in merge_mol2.py
to easily increase the molecular radius
add: call rotate_inplace in merge.py
mod: greatly increase strenght of HardSphere calculator in step 4
mod: new argument to control printing of opt-progress
add: tests for merge_with_frozen_geom() and merge_mol2_geoms()
@eljost eljost merged commit 5950976 into master Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant