Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metainfo #13

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Rename metainfo #13

merged 4 commits into from
Oct 16, 2024

Conversation

alainm23
Copy link
Contributor

@alainm23 alainm23 commented Oct 14, 2024

Fixed #3

@alainm23 alainm23 marked this pull request as draft October 14, 2024 17:07
@alainm23 alainm23 changed the title fix #3 Rename metainfo Oct 14, 2024
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Update po/extra/POTFILES too
  • Maybe we should also rename the one we generate?
src/Views/Form.vala:216:        string appdata_file = GLib.Path.build_filename (project_folder, "data", "{{PROJECT_NAME}}.appdata.xml.in");
src/Views/Form.vala:217:        string new_appdata_file = GLib.Path.build_filename (project_folder, "data", project_name + ".appdata.xml.in");

@alainm23 alainm23 marked this pull request as ready for review October 15, 2024 22:58
@alainm23 alainm23 merged commit c442bc1 into main Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appdata.xml should be metainfo.xml
2 participants