Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent style of Array.Extra #18

Merged
merged 7 commits into from
Sep 7, 2023
Merged

More consistent style of Array.Extra #18

merged 7 commits into from
Sep 7, 2023

Conversation

lue-bird
Copy link
Collaborator

@lue-bird lue-bird commented Sep 7, 2023

#4 left some minor code style inconsistencies compared to the other extra modules (many originally introduced by me)

The changes

  • replace bs |> (::) a by a :: bs
  • replace other single a |> f by f b
  • add all the parameters to the function declarations
  • annotate let declarations
  • consistently catch simple cases early

Copy link
Collaborator

@gampleman gampleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m ok with this, but I’m personally not that fussed about code style. 🤷

(given the wide range of contributors to the library I think some small variation is inevitable)

I think the main focus of the previous PR was mostly on user visible style, like the way type annotations were done.

@gampleman gampleman merged commit 15a7152 into elmcraft:master Sep 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants