-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
117 ensure fresh install works even if ifadv missing #121
117 ensure fresh install works even if ifadv missing #121
Conversation
It is not an official CRAN dependency
But still causing odd problems: tests go fine on testing, but fail on checking
For some reason, native R data files (.rda) are less comfortable for R than the good-old csv. I pushed a csv copy of the rda file to https://github.com/elpaco-escience/ifadv/tree/csv, and that's the one we are using now.
ContextDear @mdingemanse, after wrestling with the
RequestThe tests and vignettes keep running. The snapshots didn't change. But I consider this a potentially critical change in the dataset at its very origin, so it will be great if you can check the results still make sense. |
Last and perhaps least, a reflection: The original IFADV dataset was published under a permissive license. Without getting into the details, this indicates a spirit of open science and data sharing. It is ironic that this triggered an incompatibility problem with our also permissive license and ultimately forced us to apply a suboptimal solution. And a coda: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests are stable
Yes I quite agree that it would be lovely to redistribute; I remember us spending too much time early 2023 discussing the licensing constraints, and I think the IFADV makers would be scratching their heads about it. I think the current solution works around it in the most CRAN-ready way, which is our proximate goal here so approving |
I went ahead and merged, let me know if you prefer me to leave this to you as PR author next time |
ifadv
is currently hosted only in GitHub. Due to license incompatibility, we cannot just add this dataset to our package. Moreover, CRAN doesn't allow dependencies that live outside of CRAN, so we have no choice but to access it in a less elegant way.