Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helper functions and introduce a single quality check function #32

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

bvreede
Copy link
Collaborator

@bvreede bvreede commented Oct 10, 2023

  • the inspect_corpus is essentially the same as inspect_language
  • There is one unique property, which is now captured in check_quality
  • Inspect_corpus can therefore be removed
  • It is likely the check_quality function should be removed eventually, as it is an odd quality measure, and the quality checks must be much broader

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #32 (5f137cd) into main (a5ed18f) will increase coverage by 16.96%.
The diff coverage is 82.35%.

❗ Current head 5f137cd differs from pull request most recent head dcb8004. Consider uploading reports for the commit dcb8004 to get more accurate results

@@             Coverage Diff             @@
##             main      #32       +/-   ##
===========================================
+ Coverage   39.04%   56.01%   +16.96%     
===========================================
  Files           9        9               
  Lines         420      316      -104     
===========================================
+ Hits          164      177       +13     
+ Misses        256      139      -117     
Files Coverage Δ
R/summaries.R 100.00% <100.00%> (ø)
R/source_quality.R 78.57% <78.57%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bvreede bvreede merged commit 76e8cd9 into main Oct 10, 2023
2 checks passed
@bvreede bvreede deleted the refactor_inspect branch December 19, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant