Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff-hl: fix name incompatible #758

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

JiaweiChenC
Copy link
Contributor

@JiaweiChenC JiaweiChenC commented Oct 5, 2023

Issue: evil keybinding doesn't work with diff-hl popup

@JiaweiChenC JiaweiChenC marked this pull request as ready for review October 5, 2023 06:52
@JiaweiChenC
Copy link
Contributor Author

The maintainer of the diff-hl package changed the variable name from diff-hl-show-hunk--inline-popup-map to diff-hl-show-hunk-map. We should follow the name.
image
Link: dgutov/diff-hl@2ded28e#diff-3eb89b676c56131c137e621b931595b62274106922bdcbb718141cf8a0fa2969

@JiaweiChenC JiaweiChenC changed the title fix name incompatible diff-hl: fix name incompatible Oct 5, 2023
@JiaweiChenC JiaweiChenC force-pushed the fix-diff-hl-incompatible branch from 986a6a3 to a44ca0a Compare October 5, 2023 13:39
@condy0919 condy0919 merged commit 877cc09 into emacs-evil:master Oct 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants