-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and document tests #25
Conversation
There are 3 kinds of failures remaining:
The installation command failed some tests (despite
Note that this job was already failing before this change.
|
You can ignore this error for now, see emacs-eask/cli#224. |
As an example, guix package manager installs binaries in other places, so you won't find /usr/bin/c++ on a guix-managed system.
# experimental: true | ||
# - os: windows-latest | ||
# emacs-version: snapshot | ||
# experimental: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just remove the windows-latest
test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion. I mean comment out only the windows snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other two are problematic as well. as you can see, they take all the time in the world (6h), even though they will eventually pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay. I guess we can just comment them all out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 33f07a2
.github/workflows/test.yml
Outdated
@@ -17,22 +17,22 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
os: [ubuntu-latest, macos-latest] | |||
# TODO: fix lsp-sonarlint-c++-reports-issues on macos and include it | |||
os: [ubuntu-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ignore specific tests instead of entirely removing the macos-latest
? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, that's better. I ignored just lsp-sonarlint-c++-reports-issues
on macos
The tests fail now due to a problem with setup-emacs GH Action. I cannot rerun them to see if the problem is fixed. |
LGTM. Thank you for your effort on the CI tests! :D |
After the change in how
lsp-sonarlint
fetches the SonarLint executable, tests started to fail on CI, because the SonarLint executable is not downloaded automatically andlsp-mode
skips it with only a warningThis change introduces an explicit SonarLint download step before running the tests.
I decided to make it an explicit step instead of integrating it into the test harness because it can take several minutes.
Additionally, this PR documents how you can run tests locally, and makes
lsp-sonarlint-display-rule-descr-test
more reliable.