This repository has been archived by the owner on Dec 30, 2019. It is now read-only.
Feature options in project menu #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will close this issue: #10 |
Exelord
suggested changes
Jul 9, 2017
| @@ -11,12 +11,12 @@ | |||
| <span>{{t "projects.actions.remove"}}</span> | |||
| {{/content.menu-item}} | |||
|
|
|||
| {{#content.menu-item onClick="openSomething" disabled=true}} | |||
| {{#content.menu-item onClick="openInDirectory"}} | |||
There was a problem hiding this comment.
always use closure actions (action "openInDirectory") :)
|
|
||
| openInDirectory() { | ||
| let projectPath = this.get('project.path') | ||
| return this.get('terminal').execute(`nautilus ${projectPath}`) |
There was a problem hiding this comment.
nautilus?
Rather than using 3rd parties try to use official electron API:
https://github.com/electron/electron/blob/master/docs/api/shell.md
| @@ -3,12 +3,25 @@ const { Component, inject } = Ember; | |||
|
|
|||
| export default Component.extend({ | |||
| notify: inject.service(), | |||
| terminal: inject.service(), | |||
| ideName: 'code', | |||
There was a problem hiding this comment.
Hmm, hardcoded :/ I will push my changes related with settings but is still need to be tested. If you would like to practice, go ahead.
|
|
||
| actions: { | ||
| remove() { | ||
| this.get('project').destroyRecord().then(() => { | ||
| this.get('notify').success('notify.projects.remove.success'); | ||
| }); | ||
| }, | ||
|
|
||
| openInEditor() { |
There was a problem hiding this comment.
You can move these methods to terminal service and just pass them the path :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, but almost done. I think we let user define his OS and IDE, and later pass this information to component
When I come back. I will work on this feature: https://www.youtube.com/watch?v=lYGIaAkyu6M