Hints: Support 'sound-file' and 'sound-name' hints in makoctl list

criteria.c

@@ -35,6 +35,7 @@ void destroy_criteria(struct mako_criteria *criteria) {
 	free(criteria->app_icon);
 	free(criteria->category);
 	free(criteria->desktop_entry);
+	free(criteria->sound_name);
 	free(criteria->summary);
 	regfree(&criteria->summary_pattern);
 	free(criteria->body);
@@ -108,6 +109,11 @@ bool match_criteria(struct mako_criteria *criteria,
 		return false;
 	}
 
+	if (spec.sound_name &&
+			strcmp(criteria->sound_name, notif->sound_name) != 0) {
+		return false;
+	}
+
 	if (spec.summary &&
 			strcmp(criteria->summary, notif->summary) != 0) {
 		return false;
@@ -326,6 +332,10 @@ bool apply_criteria_field(struct mako_criteria *criteria, char *token) {
 			}
 			criteria->spec.group_index = true;
 			return true;
+		} else if (strcmp(key, "sound-name") == 0) {
+			criteria->sound_name = strdup(value);
+			criteria->spec.sound_name = true;
+			return true;
 		} else if (strcmp(key, "summary") == 0) {
 			criteria->summary = strdup(value);
 			criteria->spec.summary = true;

dbus/mako.c

@@ -208,6 +208,18 @@ static int handle_list(sd_bus_message *msg, struct wl_list *list) {
 			return ret;
 		}
 
+		ret = sd_bus_message_append(reply, "{sv}", "sound-file",
+			"s", notif->sound_file);
+		if (ret < 0) {
+			return ret;
+		}
+
+		ret = sd_bus_message_append(reply, "{sv}", "sound-name",
+			"s", notif->sound_name);
+		if (ret < 0) {
+			return ret;
+		}
+
 		ret = sd_bus_message_open_container(reply, 'e', "sv");
 		if (ret < 0) {
 			return ret;

dbus/xdg.c

@@ -229,6 +229,22 @@ static int handle_notify(sd_bus_message *msg, void *data,
 			}
 			free(notif->desktop_entry);
 			notif->desktop_entry = strdup(desktop_entry);
+		} else if (strcmp(hint, "sound-file") == 0) {
+			const char *sound_file = NULL;
+			ret = sd_bus_message_read(msg, "v", "s", &sound_file);
+			if (ret < 0) {
+				return ret;
+			}
+			free(notif->sound_file);
+			notif->sound_file = strdup(sound_file);
+		} else if (strcmp(hint, "sound-name") == 0) {
+			const char *sound_name = NULL;
+			ret = sd_bus_message_read(msg, "v", "s", &sound_name);
+			if (ret < 0) {
+				return ret;
+			}
+			free(notif->sound_name);
+			notif->sound_name = strdup(sound_name);
 		} else if (strcmp(hint, "value") == 0) {
 			int32_t progress = 0;
 			ret = sd_bus_message_read(msg, "v", "i", &progress);

include/criteria.h

@@ -28,6 +28,7 @@ struct mako_criteria {
 	enum mako_notification_urgency urgency;
 	char *category;
 	char *desktop_entry;
+	char *sound_name;
 	char *summary;
 	regex_t summary_pattern;
 	char *body;

include/notification.h

@@ -34,6 +34,8 @@ struct mako_notification {
 
 	char *app_name;
 	char *app_icon;
+	char *sound_file;
+	char *sound_name;
 	char *summary;
 	char *body;
 	int32_t requested_timeout;

include/types.h

@@ -50,6 +50,7 @@ struct mako_criteria_spec {
 	bool urgency;
 	bool category;
 	bool desktop_entry;
+	bool sound_name;
 	bool summary;
 	bool summary_pattern;
 	bool body;

mako.5.scd

@@ -303,6 +303,7 @@ The following fields are available in criteria:
 - _urgency_ (one of "low", "normal", "critical")
 - _category_ (string)
 - _desktop-entry_ (string)
+- _sound-name_ (string)
 - _actionable_ (boolean)
 - _expiring_ (boolean)
 - _mode_ (string)

notification.c

@@ -45,6 +45,8 @@ void reset_notification(struct mako_notification *notif) {
 
 	free(notif->app_name);
 	free(notif->app_icon);
+	free(notif->sound_file);
+	free(notif->sound_name);
 	free(notif->summary);
 	free(notif->body);
 	free(notif->category);
@@ -57,6 +59,8 @@ void reset_notification(struct mako_notification *notif) {
 
 	notif->app_name = strdup("");
 	notif->app_icon = strdup("");
+	notif->sound_file = strdup("");
+	notif->sound_name = strdup("");
 	notif->summary = strdup("");
 	notif->body = strdup("");
 	notif->category = strdup("");
@@ -97,6 +101,8 @@ void destroy_notification(struct mako_notification *notif) {
 
 	free(notif->app_name);
 	free(notif->app_icon);
+	free(notif->sound_file);
+	free(notif->sound_name);
 	free(notif->summary);
 	free(notif->body);
 	free(notif->category);

types.c

@@ -204,6 +204,8 @@ bool parse_criteria_spec(const char *string, struct mako_criteria_spec *out) {
 			out->category = true;
 		} else if (strcmp(token, "desktop-entry") == 0) {
 			out->desktop_entry = true;
+		} else if (strcmp(token, "sound-name") == 0) {
+			out->sound_name = true;
 		} else if (strcmp(token, "summary") == 0) {
 			out->summary = true;
 		} else if (strcmp(token, "body") == 0) {