Correcting binary multiplication transformation's handling of nested GDP

emma58 · Feb 18, 2024 · 664f302 · 664f302
1 parent 263d873
commit 664f302
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/pyomo/gdp/plugins/binary_multiplication.py b/pyomo/gdp/plugins/binary_multiplication.py
@@ -92,11 +92,10 @@ def _transform_disjunctionData(
             or_expr += disjunct.binary_indicator_var
             self._transform_disjunct(disjunct, transBlock)
 
-        rhs = 1 if parent_disjunct is None else parent_disjunct.binary_indicator_var
         if obj.xor:
-            xorConstraint[index] = or_expr == rhs
+            xorConstraint[index] = or_expr == 1
         else:
-            xorConstraint[index] = or_expr >= rhs
+            xorConstraint[index] = or_expr >= 1
         # Mark the DisjunctionData as transformed by mapping it to its XOR
         # constraint.
         obj._algebraic_constraint = weakref_ref(xorConstraint[index])