Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve meta tag suggestions #646

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Improve meta tag suggestions #646

wants to merge 6 commits into from

Conversation

curious-monggo
Copy link

No description provided.

@curious-monggo curious-monggo changed the title Added meta:author Add meta:author Apr 2, 2021
@curious-monggo curious-monggo changed the title Add meta:author Add meta:author and meta:charset Apr 2, 2021
@curious-monggo curious-monggo changed the title Add meta:author and meta:charset Improve meta tag suggestions Apr 4, 2021
@curious-monggo curious-monggo mentioned this pull request Apr 4, 2021
Open
@rzhao271
Copy link
Contributor

Hi @sergeche, could this PR and #676 be merged before the next emmet npm publish? Thanks in advance!

@sergeche
Copy link
Member

sergeche commented Feb 1, 2023

Hi @rzhao271, done, the #676 is merged.
However, this PR can’t be merged since "meta": "meta ${0}/", is invalid expression

@curious-monggo
Copy link
Author

Hi @rzhao271, done, the #676 is merged.
However, this PR can’t be merged since "meta": "meta ${0}/", is invalid expression

I'll look into this, this coming weekend. Thanks for scanning thru the proposed changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curious-monggo @rzhao271 @sergeche