Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve parameter validation for API #1855

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

hxy7yx
Copy link
Contributor

@hxy7yx hxy7yx commented Feb 19, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (7bfe936) 75.27% compared to head (cb4d477) 75.37%.
Report is 10 commits behind head on main.

Files Patch % Lines
plugins/restful/group_config_handle.c 53.84% 6 Missing ⚠️
src/adapter/adapter.c 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
+ Coverage   75.27%   75.37%   +0.09%     
==========================================
  Files          99       99              
  Lines       17216    17305      +89     
==========================================
+ Hits        12959    13043      +84     
- Misses       4257     4262       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hxy7yx hxy7yx force-pushed the main-1 branch 5 times, most recently from 11c0ae5 to 62d7738 Compare February 20, 2024 01:39
Copy link
Member

@fengzeroz fengzeroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using macros, reduce the use of goto

@hxy7yx hxy7yx force-pushed the main-1 branch 13 times, most recently from db483cd to d6ef635 Compare February 21, 2024 08:31
@fengzeroz fengzeroz merged commit 0c80221 into emqx:main Feb 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants