Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release reviewers to release creation PRs #1455

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Add release reviewers to release creation PRs #1455

merged 3 commits into from
Oct 15, 2024

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Oct 12, 2024

No description provided.

@dschuff
Copy link
Member Author

dschuff commented Oct 12, 2024

testing @emscripten-core/release-reviewers

@aheejin
Copy link
Member

aheejin commented Oct 12, 2024

Nice! Is this meant to just cc the mailing list? Or is adding it to the actual reviewer the next step?

@dschuff
Copy link
Member Author

dschuff commented Oct 12, 2024

I think github is supposed to notify each member of the team individually, not the bot account.

@dschuff
Copy link
Member Author

dschuff commented Oct 12, 2024

Oh and yes, this PR is supposed to add actual reviewers.

@dschuff
Copy link
Member Author

dschuff commented Oct 12, 2024

I'll test this after the real PR comes through, should just be a few minutes from now.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dschuff dschuff mentioned this pull request Oct 15, 2024
@dschuff
Copy link
Member Author

dschuff commented Oct 15, 2024

I think it's working now. interesting that the action will update an existing PR if one exists rather than creating a new one.

@dschuff
Copy link
Member Author

dschuff commented Oct 15, 2024

@walkingeyerobot it seems unrelated to this PR (which doesn't affect any tests), but the test-bazel-windows build seems to be failing.

@dschuff dschuff merged commit 8e661c8 into main Oct 15, 2024
10 of 11 checks passed
@dschuff dschuff deleted the dschuff-patch-1 branch October 15, 2024 00:27
@walkingeyerobot
Copy link
Collaborator

The failure was on downloading some bazel stuff from github that was erroring out. Last night I was able to reproduce, but today the link works again and the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants