-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release reviewers to release creation PRs #1455
Conversation
testing @emscripten-core/release-reviewers |
Nice! Is this meant to just cc the mailing list? Or is adding it to the actual reviewer the next step? |
I think github is supposed to notify each member of the team individually, not the bot account. |
Oh and yes, this PR is supposed to add actual reviewers. |
I'll test this after the real PR comes through, should just be a few minutes from now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think it's working now. interesting that the action will update an existing PR if one exists rather than creating a new one. |
@walkingeyerobot it seems unrelated to this PR (which doesn't affect any tests), but the test-bazel-windows build seems to be failing. |
The failure was on downloading some bazel stuff from github that was erroring out. Last night I was able to reproduce, but today the link works again and the tests pass. |
No description provided.