Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Last Will (LWT) not set on MQTT Connect #2247 #2248

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix Last Will (LWT) not set on MQTT Connect #2247 #2248

merged 3 commits into from
Nov 25, 2024

Conversation

proddy
Copy link
Contributor

@proddy proddy commented Nov 24, 2024

No description provided.

MichaelDvP
MichaelDvP requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@MichaelDvP MichaelDvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way and works on the unsecure client, setting for secureclient is missing.

src/mqtt.cpp Outdated Show resolved Hide resolved
lib/framework/MqttSettingsService.cpp Outdated Show resolved Hide resolved
@proddy proddy merged commit c59657a into emsesp:dev Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDvP MichaelDvP MichaelDvP requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proddy @MichaelDvP