Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyGIMLi(emg3d) #328

Closed
wants to merge 6 commits into from
Closed

pyGIMLi(emg3d) #328

wants to merge 6 commits into from

Conversation

prisae
Copy link
Member

@prisae prisae commented Jun 21, 2024

pyGIMLi(emg3d)

Implementing an emg3d.inversion submodule with a first member pygimli, providing the two classes emg3d.inversion.pygimli.Kernel and emg3d.inversion.pygimli.Inversion to run an inversion using the pyGIMLi framework and emg3d as a forward modelling kernel.

TODOs:

  • Clean-up; better document; add some text to inversion/__init__.py and inversion.pygimli.py files
  • Implement lazy import with __getattr__ for the inversion modules.
  • Add tests; tests are implemented, but pyGIMLi tests are skipped on the CI -- WHY?
  • Add example; https://github.com/emsig/emg3d-gallery/tree/dev

NOTE

With massive help from @halbmy and lots of testing from @mariacarrizo !

@prisae prisae added the enhancement New feature or request label Jun 21, 2024
@prisae prisae marked this pull request as draft June 21, 2024 13:13
@prisae prisae force-pushed the inversion branch 2 times, most recently from 63ff8c6 to 868edad Compare June 23, 2024 13:20
@prisae prisae marked this pull request as ready for review June 23, 2024 13:28
@emsig emsig deleted a comment from coveralls Jun 29, 2024
@emsig emsig deleted a comment from coveralls Jun 29, 2024
@emsig emsig deleted a comment from coveralls Jun 29, 2024
@emsig emsig deleted a comment from coveralls Jun 29, 2024
@emsig emsig deleted a comment from coveralls Jun 30, 2024
@emsig emsig deleted a comment from coveralls Jul 1, 2024
@emsig emsig deleted a comment from coveralls Jul 1, 2024
Implemented tests for inversion.pygimli.

For some reasons, it fails to import pygimli on the GHA.

Testing takes place on branch `testing`
@prisae
Copy link
Member Author

prisae commented Jul 5, 2024

Somehow the tests stopped being triggered in this. Trying with a new PR...

@prisae prisae closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant