Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement workspace dependencies #149

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

rjzak
Copy link
Member

@rjzak rjzak commented Dec 12, 2022

Closes #121
Depends on #146

Signed-off-by: Richard Zak [email protected]

@rjzak rjzak requested review from a team, bstrie and haraldh as code owners December 12, 2022 19:12
@rjzak rjzak changed the title chore: refactor unit tests chore: implement workspace dependencies Dec 12, 2022
@rjzak rjzak force-pushed the workspace-dependencies branch from 89afbbc to 32ded50 Compare December 12, 2022 20:40
@rjzak rjzak marked this pull request as draft December 12, 2022 20:48
@rjzak rjzak force-pushed the workspace-dependencies branch from 32ded50 to a176a5e Compare December 12, 2022 20:51
@rjzak rjzak marked this pull request as ready for review December 12, 2022 20:51
@rvolosatovs
Copy link
Member

@rjzak please rebase

@rjzak rjzak force-pushed the workspace-dependencies branch from a176a5e to 5832dd0 Compare December 13, 2022 17:05
@rjzak rjzak closed this Dec 13, 2022
@rjzak
Copy link
Member Author

rjzak commented Dec 13, 2022

Close & reopen since Github CI seems to be broken.

@rjzak rjzak reopened this Dec 13, 2022
Copy link
Member

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move features = blocks into the actual crate dependencies that need them

Cargo.toml Outdated Show resolved Hide resolved
@rjzak rjzak force-pushed the workspace-dependencies branch from 5832dd0 to fb01fbe Compare December 13, 2022 17:51
@rjzak rjzak requested a review from rvolosatovs December 13, 2022 18:04
@rvolosatovs rvolosatovs merged commit fb01fbe into enarx:main Dec 13, 2022
@rjzak rjzak deleted the workspace-dependencies branch December 13, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt workspace dependencies
2 participants