Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for controlling eebus-go via JSON-RPC from another process #128

Merged
merged 34 commits into from
Oct 28, 2024
Merged

Add support for controlling eebus-go via JSON-RPC from another process #128

merged 34 commits into from
Oct 28, 2024

Commits on Oct 23, 2024

  1. Add basic structure for a Remote interface to the EEBus use-cases

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f0ea56c View commit details
    Browse the repository at this point in the history

  2. Ensure jsonrpc packets are newline framed

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b5dcc34 View commit details
    Browse the repository at this point in the history

  3. Register LPC use case and propagate events as JSON-RPC notifications

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d048fc2 View commit details
    Browse the repository at this point in the history

  4. Add functionality to automatically register exported methods

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    587506e View commit details
    Browse the repository at this point in the history

  5. Add util for saving generated keys

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    fd67f03 View commit details
    Browse the repository at this point in the history

  6. Cleanup rpc calling

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1cbaf34 View commit details
    Browse the repository at this point in the history

  7. Pass entityAddress as argument for notifications

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1dd6fe8 View commit details
    Browse the repository at this point in the history

  8. Add Bind function to RpcServer to register new connections

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    15e3eae View commit details
    Browse the repository at this point in the history

  9. Scope notification methods similar to calls

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8dcd8fe View commit details
    Browse the repository at this point in the history

  10. Unmarshal json parameters directly to function parameter slice 

    Allows unmarshalling structs instead of unmarshalling to map
    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    275470a View commit details
    Browse the repository at this point in the history

  11. Provide device SKI in notifications to allow device mapping

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e524882 View commit details
    Browse the repository at this point in the history

  12. Ensure that we can scope use cases fully when registering. 

    Allows registering e.g. EG-LPC and CS-LPC on the same remote
    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c0d68ab View commit details
    Browse the repository at this point in the history

  13. Lock access to entityInterfaces map

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ad79200 View commit details
    Browse the repository at this point in the history

  14. Handle nullable parameters and functions returning (error, value)

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    af880bb View commit details
    Browse the repository at this point in the history

  15. Add ConnectedDevices function to get list of connected RemotDevices

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0241dab View commit details
    Browse the repository at this point in the history

  16. Fix panic when EntityRemoteInterface parameter is null

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f366a83 View commit details
    Browse the repository at this point in the history

  17. Add RemoteDeviceInfo function to wrap RemoteDeviceForSki

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    57680f3 View commit details
    Browse the repository at this point in the history

  18. Fix several possible nil dereferences

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b1fbe82 View commit details
    Browse the repository at this point in the history

  19. Check method calls for correct number of parameters

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e2aec46 View commit details
    Browse the repository at this point in the history

  20. Allow specifying mdns info via arguments

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    92a774c View commit details
    Browse the repository at this point in the history

  21. If an explicit interface is specified, wait until the interface is 

    available for mdns before initialising
    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f34154e View commit details
    Browse the repository at this point in the history

  22. Map directly between AddressTypes and interfaces using appropriate 

    functions
    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d8fc201 View commit details
    Browse the repository at this point in the history

  23. Adjust callback for RemoteSKIConnected to return device address

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    79e1236 View commit details
    Browse the repository at this point in the history

  24. Add basic log interface to rpcService

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    93dabf9 View commit details
    Browse the repository at this point in the history

  25. Split out reflection api and add Call interface for device/entities

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8e6e54b View commit details
    Browse the repository at this point in the history

  26. Add SKI to all notifications 

    This is useful so we can call UnregisterRemoteSKI for unknown/unwanted devices
    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    35fd334 View commit details
    Browse the repository at this point in the history

  27. RemoteSKIDisconnected returns ski not device

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2bb5593 View commit details
    Browse the repository at this point in the history

  28. feat: enable missing ucs

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    dbca882 View commit details
    Browse the repository at this point in the history

  29. Accept requests omitting the params field. 

    According to spec, the field may be omitted and should be treated as
calling a function without parameters.
    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    132c1f3 View commit details
    Browse the repository at this point in the history

  30. added missing notifications to api.ServiceReaderInterface

    @sthelen-enqs
    Martin.Beims authored and sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    05f2a7f View commit details
    Browse the repository at this point in the history

  31. Fix compilation after sync on dev

    @sthelen-enqs
    sthelen-enqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0c940e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Explicitly ignore the return type of conn.Notify 

    Sending a notification can only fail if JSON serialization fails, or if
writing to the socket fails.

We can't handle JSON serialization failures here, and if writing to the
socket fails the connection should be dropped by the json-rpc
implementation anyway.
    @sthelen-enqs
    sthelen-enqs committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    44c4778 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Always return argument responses as complete array. 

    All eebus-go functions will now return a JSON array which includes all
return parameters including any error values.

NOTE: This is a breaking change
    @sthelen-enqs
    sthelen-enqs committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    7abed76 View commit details
    Browse the repository at this point in the history

  2. Forward potential errors from registerStaticReceiverProxy up through 

    RegisterUseCase.

These errors are currently always API misuse, but it might be nice to
extend RegisterUseCase to allow returning errors anyway.
    @sthelen-enqs
    sthelen-enqs committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    cf8b0d6 View commit details
    Browse the repository at this point in the history