Forward error types as their string representation #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default go serializes
error
types as an empty struct{}
, this patch would adjust that so that errors are serialized as their string representation by callingError()
on any non-nil types that implement the error interface.This should be an improvement over the current state as it now allows identifying the cause of an error from the RPC client. An alternative could be to serialize the error as a struct of
{"type": <>, "message": <>}
using reflection to get the type name (and package path) of the error though I'm not sure if it's necessary and I'd have to check how easy that would be to get working.