Fix inconsistent DataUpdate event type identifiers for LPP use cases #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks you very much @anjrew ! Much appreciated. |
DerAndereAndi
added a commit
that referenced
this pull request
Nov 11, 2024
This also allows differentiating between eglpc.DataUpdateHeartbeat and cslpc.DataUpdateHeartbeat events. While syncing my branch on dev, I saw #137 and noticed that the DataUpdateHeartbeat events for eg/lpc and cs/lpc used the same identifier which means they can't be differentiated from another over e.g. json-rpc. I also took the liberty of changing the "uclppserver-" identifier to "cs-lpp-" to make it consistent with the other event names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves inconsistencies in the event type identifiers within usecases/cs/lpp/types.go and usecases/eg/lpp/types.go. The following changes were made:
These changes improve code accuracy, documentation and maintain the correct mapping of constants to their respective use cases in the EEBUS library.