-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add democracy documentation #16
Conversation
src/protocol-democracy.md
Outdated
../target/release/encointer-client-notee -u ws://127.0.0.1 -p 9944 vote //Bob 2 nay sqm1v79dF6b_1 | ||
# Charlie votes aye for proposal 2 | ||
../target/release/encointer-client-notee -u ws://127.0.0.1 -p 9944 vote //Charlie 2 aye sqm1v79dF6b_1 | ||
# Waiting 5 blocks... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as confirmation period is set to 10 blocks and we already waited 6 blocks during the voting process
src/protocol-democracy.md
Outdated
# Alice updates proposal state of proposal 2 | ||
../target/release/encointer-client-notee -u ws://127.0.0.1 -p 9944 update-proposal-state //Alice 2 | ||
../target/release/encointer-client-notee -u ws://127.0.0.1 -p 9944 list-proposals | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after just reading this, I don't get what the expected outcome of this tutorial is. I suggest to break up this console blob into meaningful pieces and add educational prosa
Questions:
- the timing of the entire process is unclear to me. You're just waiting a couple of blocks for the whole flow. Is there any relevance of cycle phases at all?
- would it make sense to have participants with varying reputation to demonstrate the mechanics of voting power?
- enactment: With these commands I don't see that the proposals had an effect ( or not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- cycles dont have any relevance, only confirmation period and reputation lifetime.
- could make sense, but i suggest that this is a basic tutorial and this is enough.
- we see that the proposal is approved and in the enactment queue. we just dont wait for the enactment.
cd encointer-node && git fetch && git checkout origin/personhood-democracy-1-delivery | ||
cd .. | ||
git clone https://github.com/encointer/pallets.git | ||
mv pallets/ encointer-pallets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth following repo naming in your working folder and patch accordingly ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought i was following a convention here
https://github.com/encointer/encointer-node/blob/0a2351432bd46716c2a06e7e112ee8459ef9f7b1/Cargo.toml#L14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the problem is I never committed patches, so this never got updated after the repo renaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Haven't tested the tutorial though.
I leave it to you if you want to modify along above comment.
ok thanks :) i added a second vote for alice, to show that only 1 vote will be counted. |
No description provided.