polkadot v1.2.0 #207
Merged
polkadot v1.2.0 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
commented
Nov 2, 2023
Comment on lines
-682
to
-686
| // Encointer customization: This part is different from upstream. We don't use the relay | ||
| // consensus part from further below, we start with aura consensus directly. | ||
| // | ||
| // We do this because our launch-runtime comes with consensus, whereas the upstream | ||
| // shell runtime does not have that. |
There was a problem hiding this comment.
I think we can get rid of this legacy now. agree @clangenb ?
don't think it will ever happen again that we start with a shell which isn't launch-runtime
There was a problem hiding this comment.
The issue was different, there was extra code from upstream, which we didn't use, and so we removed it, but when I look at the code, it seems that we have harmonized it with upstream now anyhow. So we can remove it.
clangenb
approved these changes
Nov 6, 2023
Comment on lines
-682
to
-686
| // Encointer customization: This part is different from upstream. We don't use the relay | ||
| // consensus part from further below, we start with aura consensus directly. | ||
| // | ||
| // We do this because our launch-runtime comes with consensus, whereas the upstream | ||
| // shell runtime does not have that. |
There was a problem hiding this comment.
The issue was different, there was extra code from upstream, which we didn't use, and so we removed it, but when I look at the code, it seems that we have harmonized it with upstream now anyhow. So we can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #206
list-communitiesbecause of a semver violation, I had to
cargo update -p [email protected]. see here