CORS fixes #1587
Merged
CORS fixes #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
fredr
force-pushed
the
fredr/ts-cors-fixes
branch
from
0f0683b
to
6991060
Compare
…eaders if e.g origin isnt allowed
eandre
reviewed
Nov 25, 2024
eandre
reviewed
Nov 25, 2024
eandre
approved these changes
Nov 26, 2024
fredr
commented
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the test cases from the go runtime to the rust runtime and makes them pass.
It also adds a check on OPTIONS requests on access-control-request-headers to check if its a request with credentials, as the authorization header is not passed on OPTIONS requests.