Test mode cleanups #416
Merged
Test mode cleanups #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was needed in the distant path where /etc was handled differently to other mutable paths on live boots, but since commit 4d348fb and commit 37d20f1 etc has been part of the overlay_dirs list that EXTRA_PATHS is appended to, so passing etc to this script has been redundant. Remove it; and remove the EXTRA_PATHS handling from eos-live-boot-overlayfs-setup, which is now unused. https://phabricator.endlessm.com/T35651
We have a checkpoint that prevents upgrading from EOS 4 to EOS 5 if the flatpak and ostree repos have not been split; and this script is typically only used on fresh installs/live images anyway. https://phabricator.endlessm.com/T35651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T35651