Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Strings as types #39

Closed
wants to merge 2 commits into from
Closed

WIP: Strings as types #39

wants to merge 2 commits into from

Conversation

wnbaum
Copy link
Contributor

@wnbaum wnbaum commented Jun 17, 2024

No description provided.

@wnbaum wnbaum force-pushed the strings-as-types branch from 56ed47d to c99abcf Compare June 17, 2024 19:48
@manuq
Copy link
Contributor

manuq commented Jun 18, 2024

Honestly I would prefer to keep things as before in a custom ENUM rather than allowing arbitrary strings for the types.

Here is my alternative: #43

@wnbaum wnbaum mentioned this pull request Jun 18, 2024
Merged
@wjt
Copy link
Member

wjt commented Jun 19, 2024

Based on #43 having been merged, should we close this?

@manuq manuq closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wnbaum @manuq @wjt