instruction_tree: Pass depth & output buffer as parameters #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter here is not necessarily the root of the tree.
The depth is a transient property of where in the tree we happen to be generating code, so it should not be a persistent property of the class. Pass it explicitly.
From an efficiency point of view, repeatedly appending to an immutable string probably involves repeatedly copying the string. (Some languages have an optimisation where if `s` is the only reference to a string, then `s += "foo"` modifies `s` in place; I don't know if GDScript has that.) From a clarity perspective, it is strange for the output buffer to be an instance variable of the InstructionTree – it is a transient buffer used during a call to generate_text(). Replace it with a PackedStringArray, passed through the recursive calls, containing lines of code. Join it to produce the generated code as a whole.
wjt
force-pushed
the
simplify-instructiontree
branch
from
6b71011 to
5378c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is clearer than using instance variables, which persist beyond the call to generate_text, to store state which is transient to any given call to generate_text. It's also shorter!