Final P.R. to update to 1.21.3 #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Formatting?
Run Formatting? Edit: Run Datagen?
|
Are you sure this is based on the 1.21 branch? There seem to be a lot of merge conflicts. Also, some of the issues I mentioned in the previous PR aren't addressed. Did you push the wrong branch by accident? |
|
I don't think so? I already went over it twice, but I'll check it a third. Sorry for the hassle |
|
Like three of them seem to be legitimate, the rest I don't know? |
|
|
I think this is ready, despite the merge conflicts? |
|
I don't see any issues I didn't change from the previous pr either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed all the changes requested in #35, changed updated branch to 1.21.1/dev