fix: 🐛 propellerheads

enkryptcom · Mar 21, 2024 · 3e2979a · 3e2979a · github-actions · Mar 21, 2024
1 parent 1e2ff20
commit 3e2979a
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/packages/swap/src/providers/propeller-heads/index.ts b/packages/swap/src/providers/propeller-heads/index.ts
@@ -132,17 +132,14 @@ class PropellerHeads extends ProviderClass {
       this.network !== options.toToken.networkInfo.name
     )
       return Promise.resolve(null);
-
-    if (options.fromAddress.toLowerCase() !== options.toAddress.toLowerCase())
-      return Promise.resolve(null);
-
     const body = {
       orders: [
         {
           sell_token: options.fromToken.address,
           buy_token: options.toToken.address,
           sell_amount: options.amount.toString(),
           origin_address: options.fromAddress,
+          receiver: options.toAddress,
         },
       ],
     };
@@ -151,7 +148,6 @@ class PropellerHeads extends ProviderClass {
       blockchain:
         NetworkNamesToSupportedProppellerHeadsBlockchains[this.network],
     });
-
     return fetch(`${BASE_URL}/solver/solve?${params.toString()}`, {
       method: "POST",
       body: JSON.stringify(body),
@@ -174,7 +170,10 @@ class PropellerHeads extends ProviderClass {
           from: options.fromAddress,
           gasLimit: GAS_LIMITS.swap,
           to: options.fromAddress,
-          value: numberToHex(options.amount),
+          value:
+            options.fromToken.address === NATIVE_TOKEN_ADDRESS
+              ? numberToHex(options.amount)
+              : "0x0",
           data: response.solutions[0].call_data,
           type: TransactionType.evm,
         });

diff --git a/packages/swap/tests/propeller-heads.test.ts b/packages/swap/tests/propeller-heads.test.ts
@@ -7,7 +7,12 @@ import {
   SupportedNetworkName,
   WalletIdentifier,
 } from "../src/types";
-import { fromTokenWBTC, toToken, nodeURL } from "./fixtures/mainnet/configs";
+import {
+  fromTokenWBTC,
+  toToken,
+  nodeURL,
+  toAddress,
+} from "./fixtures/mainnet/configs";
 
 describe("Propeller Heads Provider", () => {
   const web3eth = new Web3Eth(nodeURL);
@@ -22,10 +27,10 @@ describe("Propeller Heads Provider", () => {
     const quote = await propellerHeads.getQuote(
       {
         amount: localAmount,
-        fromAddress: "0x9ff58f4ffb29fa2266ab25e75e2a8b3503311656", // aave
+        fromAddress: "0x6daB3bCbFb336b29d06B9C793AEF7eaA57888922", // random address
         fromToken: fromTokenWBTC,
         toToken,
-        toAddress: "0x9ff58f4ffb29fa2266ab25e75e2a8b3503311656", // aave
+        toAddress,
       },
       { infiniteApproval: true, walletIdentifier: WalletIdentifier.enkrypt }
     );
@@ -53,10 +58,10 @@ describe("Propeller Heads Provider", () => {
     const quote = await propellerHeads.getQuote(
       {
         amount: localAmount,
-        fromAddress: "0x9ff58f4ffb29fa2266ab25e75e2a8b3503311656", // aave
+        fromAddress: "0x6daB3bCbFb336b29d06B9C793AEF7eaA57888922", // random address
         fromToken: fromTokenWBTC,
         toToken,
-        toAddress: "0x9ff58f4ffb29fa2266ab25e75e2a8b3503311656", // aave
+        toAddress,
       },
       { infiniteApproval: false, walletIdentifier: WalletIdentifier.enkrypt }
     );

diff --git a/packages/swap/tests/swap.test.ts b/packages/swap/tests/swap.test.ts
@@ -76,7 +76,7 @@ describe("Swap", () => {
     const propellerHeadsQuote = quotes.find(
       (q) => q.provider === ProviderName.propellerHeads
     );
-    if (quotes?.length > 3) {
+    if (quotes?.length > 4) {
       const rangoQuote = quotes.find((q) => q.provider === ProviderName.rango);
       expect(rangoQuote!.provider).to.be.eq(ProviderName.rango);
     }
@@ -102,7 +102,7 @@ describe("Swap", () => {
       toToken,
       toAddress: fromAddress,
     });
-    expect(quotes?.length).to.be.gte(4);
+    expect(quotes?.length).to.be.gte(5);
     const oneInceQuote = quotes.find(
       (q) => q.provider === ProviderName.oneInch
     );