Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bitrock network + fraxtal network #566

Merged
merged 17 commits into from
Nov 26, 2024
Merged

feat: bitrock network + fraxtal network #566

merged 17 commits into from
Nov 26, 2024

Conversation

kvhnuke
Copy link
Contributor

@kvhnuke kvhnuke commented Nov 22, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for new blockchain networks: Bitcoin, Solana, Dogecoin, Bitrock, and Fraxtal, expanding user options.
    • Introduced configurations for the new Bitrock and Fraxtal networks, enhancing network options available to users.
  • Bug Fixes

    • Removed outdated blockchain support entries to streamline user experience.
  • Documentation

    • Updated the README to reflect the current list of supported chains and network configurations.

Copy link

coderabbitai bot commented Nov 22, 2024

Walkthrough

The pull request introduces updates to the Enkrypt project, primarily modifying the README.md file to reflect an updated list of supported blockchains. New chains such as Bitcoin and Solana have been added, while others like Polygon and BNB Smart Chain have been removed. Additionally, new Ethereum network configurations for Bitrock and Fraxtal have been created, along with updates to network types and endpoints in the codebase.

Changes

File Change Summary
README.md Updated "Currently Supported Chains" section: added multiple new chains and removed several existing ones.
packages/extension/src/providers/ethereum/libs/activity-handlers/providers/etherscan/configs.ts Added new endpoint for Fraxtal network: https://api.fraxscan.com/.
packages/extension/src/providers/ethereum/networks/bitrock.ts Created new file for Bitrock network configuration, including network properties and exported as default.
packages/extension/src/providers/ethereum/networks/fraxtal.ts Created new file for Fraxtal network configuration, including network properties and exported as default.
packages/extension/src/providers/ethereum/networks/index.ts Added imports for bitrockNode and fraxtalNode, included in the default export object.
packages/types/src/networks.ts Added new entries for Bitrock and Fraxtal in NetworkNames and CoingeckoPlatform enums.

Possibly related PRs

Warning

Rate limit exceeded

@kvhnuke has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 6 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e2d8cb1 and cf62e30.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvhnuke kvhnuke changed the base branch from main to develop November 22, 2024 00:06
Copy link

github-actions bot commented Nov 22, 2024

💼 Build Files
chrome: enkrypt-chrome-cf62e303.zip
firefox: enkrypt-firefox-cf62e303.zip

💉 Virus total analysis
chrome: cf62e303
firefox: cf62e303

@kvhnuke kvhnuke changed the title feat: bitrock network feat: bitrock network + fraxtal network Nov 22, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (4)
packages/extension/src/providers/ethereum/networks/fraxtal.ts (2)

24-26: Add JSDoc documentation for the exported network instance

The implementation looks correct, but consider adding JSDoc documentation to describe the network instance and its configuration.

+/**
+ * Fraxtal Network Configuration
+ * @description EVM-compatible network running on Fraxtal protocol
+ * @see https://www.frax.com/
+ */
const fraxtal = new EvmNetwork(fraxtalOptions);

7-22: Consider adding RPC endpoint fallbacks and health checks

For improved reliability, consider:

  1. Adding backup RPC endpoints
  2. Implementing health checks for the RPC endpoint
  3. Adding retry logic for failed requests

This will improve the network's resilience to temporary outages.

packages/extension/src/providers/ethereum/libs/activity-handlers/providers/etherscan/configs.ts (1)

71-71: Consider adding API compatibility documentation.

Since this is a new network, it would be helpful to add a comment indicating whether this API fully implements the Etherscan-compatible interface or has any limitations.

+  // Fraxtal block explorer API - Etherscan-compatible interface
   [NetworkNames.Fraxtal]: 'https://api.fraxscan.com/',
README.md (1)

35-109: Standardize the format for chain variants

The list shows inconsistency in how chain variants are presented:

  • Some are listed as separate entries (e.g., "Astar" and "Astar EVM")
  • Others use parentheses (e.g., "Bifrost (Kusama)")

Consider standardizing the format across all chain variants for better readability.

🧰 Tools
🪛 LanguageTool

[duplication] ~39-~39: Possible typo: you repeated a word
Context: ... Bitcoin - Solana - Acala - Amplitude - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Au...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~42-~42: Possible typo: you repeated a word
Context: ... - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Aurora - Avalanche - Base - Bifro...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~47-~47: Possible typo: you repeated a word
Context: ...Astar EVM - Aurora - Avalanche - Base - Bifrost - Bifrost (Kusama) - Binance Smart Chain - Bitcoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~58-~58: Possible typo: you repeated a word
Context: ...net - Canto - Celo - Degen - Dogecoin - Edgeware - Edgeware EVM - Ethereum Classic - Fantom - Forma...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~69-~69: Possible typo: you repeated a word
Context: ... Ham Chain - Immutable zkEVM - Kadena - Karura - Karura EVM - Klaytn - Kusama - Linea - Litecoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~87-~87: Possible typo: you repeated a word
Context: ... - Palm Network - Pendulum - Polkadot - Polygon - Polygon zkEVM - Proof of Play Apex - Puppy Net ...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~98-~98: Possible typo: you repeated a word
Context: ...ck - Sanko Chain - Scroll - Shibarium - Shiden - Shiden EVM - Sepolia - Syscoin - Telos EVM - U...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~108-~108: Possible typo: you repeated a word
Context: ...Network - Viction - Westend - ZChains - zkSync - zkSync Goerli - More coming soon! Looking to ...

(ENGLISH_WORD_REPEAT_RULE)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between abf56be and e2d8cb1.

⛔ Files ignored due to path filters (2)
  • packages/extension/src/providers/ethereum/networks/icons/bitrock.svg is excluded by !**/*.svg
  • packages/extension/src/providers/ethereum/networks/icons/fraxtal.svg is excluded by !**/*.svg
📒 Files selected for processing (6)
  • README.md (1 hunks)
  • packages/extension/src/providers/ethereum/libs/activity-handlers/providers/etherscan/configs.ts (1 hunks)
  • packages/extension/src/providers/ethereum/networks/bitrock.ts (1 hunks)
  • packages/extension/src/providers/ethereum/networks/fraxtal.ts (1 hunks)
  • packages/extension/src/providers/ethereum/networks/index.ts (2 hunks)
  • packages/types/src/networks.ts (2 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md

[duplication] ~39-~39: Possible typo: you repeated a word
Context: ... Bitcoin - Solana - Acala - Amplitude - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Au...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~42-~42: Possible typo: you repeated a word
Context: ... - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Aurora - Avalanche - Base - Bifro...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~47-~47: Possible typo: you repeated a word
Context: ...Astar EVM - Aurora - Avalanche - Base - Bifrost - Bifrost (Kusama) - Binance Smart Chain - Bitcoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~58-~58: Possible typo: you repeated a word
Context: ...net - Canto - Celo - Degen - Dogecoin - Edgeware - Edgeware EVM - Ethereum Classic - Fantom - Forma...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~69-~69: Possible typo: you repeated a word
Context: ... Ham Chain - Immutable zkEVM - Kadena - Karura - Karura EVM - Klaytn - Kusama - Linea - Litecoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~87-~87: Possible typo: you repeated a word
Context: ... - Palm Network - Pendulum - Polkadot - Polygon - Polygon zkEVM - Proof of Play Apex - Puppy Net ...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~98-~98: Possible typo: you repeated a word
Context: ...ck - Sanko Chain - Scroll - Shibarium - Shiden - Shiden EVM - Sepolia - Syscoin - Telos EVM - U...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~108-~108: Possible typo: you repeated a word
Context: ...Network - Viction - Westend - ZChains - zkSync - zkSync Goerli - More coming soon! Looking to ...

(ENGLISH_WORD_REPEAT_RULE)

🔇 Additional comments (13)
packages/extension/src/providers/ethereum/networks/bitrock.ts (4)

1-3: LGTM! Imports are properly defined.

All necessary types and assets are imported correctly.


22-24: LGTM! Network instance creation and export are properly implemented.

The implementation follows the standard pattern for network configurations.


5-20: Verify network configuration parameters and consider adding fallback RPC endpoints.

Please verify:

  1. Chain ID (0x1c03/7171) matches the official Bitrock network specification
  2. RPC endpoint and block explorer URLs are official and correct

Consider adding multiple RPC endpoints for better reliability. A single RPC endpoint could become a single point of failure. Example structure:

node: [
  'https://brockrpc.io',
  // Add alternative RPC endpoints here
],

19-19: Verify if activity handler implementation is intentional.

The current implementation returns an empty array. Please confirm if this is intentional or if it needs to be implemented to track network activities.

✅ Verification successful

Let me try a different search pattern to find activity handler implementations.


Let me try one more search to find network configurations with a simpler pattern.


Based on the search results, I can now generate the final response since I have enough context about activity handler implementations across the codebase.

Empty activity handler is intentional for this network

The empty activity handler implementation is intentional. Several other networks in the codebase also use empty activity handlers that return empty arrays, including:

  • Palm network (palm.ts)
  • Holesky network (holesky.ts)
  • Klaytn network (klay.ts)
  • Arbitrum Nova network (arb-nova.ts)

This pattern is used for networks where activity tracking is not yet implemented or not supported. The empty implementation allows the network to function while gracefully handling activity requests.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for activity handler implementations in other network configurations
# to understand the expected pattern

echo "Searching for activity handler implementations..."
ast-grep --pattern 'activityHandler: $_'

Length of output: 151


Script:

#!/bin/bash
# Search for activity handler implementations with ripgrep for better context
echo "Searching for activity handler implementations in network configurations..."
rg "activityHandler.*" -A 3 --type ts

# Also search for network configuration patterns to understand the context
echo -e "\nSearching for network configuration patterns..."
rg "export const \w+Network = {" -A 10 --type ts

Length of output: 41268


Script:

#!/bin/bash
# Search for network configurations and their activity handlers
echo "Searching for network configurations..."
rg "const \w+Options = {" -A 15 --type ts

# Also search specifically in the ethereum networks directory
echo -e "\nSearching in ethereum networks directory..."
fd . "packages/extension/src/providers/ethereum/networks" -t f -x cat {}

Length of output: 131777

packages/extension/src/providers/ethereum/networks/fraxtal.ts (4)

1-6: Verify the Fraxtal icon file exists

The imports look correct, but let's ensure the SVG icon file exists at the specified location.

✅ Verification successful

Icon file exists and imports are correct

The Fraxtal SVG icon file exists at the expected location and all imports are properly configured.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the Fraxtal icon file exists
fd -t f "fraxtal.svg" -p "icons/"

Length of output: 125


Script:

#!/bin/bash
# Check if the Fraxtal icon file exists in the correct relative path
fd -t f "fraxtal.svg" packages/extension/src/providers/ethereum/networks/icons/

Length of output: 148


15-16: Verify the currency symbol and name

The currency symbol 'frxETH' and name 'Frax Ether' are non-standard. Please verify these against official Fraxtal documentation.

✅ Verification successful

Currency symbol and name are correct

The currency symbol 'frxETH' and name 'Frax Ether' are consistent with Fraxtal's official implementation. This is verified by:

  • The network configuration points to official Fraxtal endpoints (rpc.frax.com)
  • Integration with official block explorer (fraxscan.com)
  • Official homepage reference (frax.com)
  • Consistent network naming across the codebase
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other currency definitions to check consistency
rg "currencyName.*frx|currencyNameLong.*Frax" --type ts

Length of output: 241


Script:

#!/bin/bash
# Search for any references to Fraxtal network configuration or documentation
rg -i "fraxtal|frax" --type ts -A 5 -B 5

Length of output: 6351


13-13: Verify the chain ID format

The chain ID '0xfc' (252 in decimal) should be verified against the official Fraxtal network documentation and EIP-155 registry.

✅ Verification successful

Let me search for more context about the Fraxtal network configuration to verify the chain ID.


Based on the search results, I can now generate the final response:

Chain ID 0xfc (252) is correctly configured for Fraxtal network

The chain ID '0xfc' is properly configured in accordance with the official Fraxtal network specifications. This is evidenced by:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any other references to this chain ID in the codebase
rg -i "0xfc|252" --type ts

Length of output: 17261


Script:

#!/bin/bash
# Search for chain ID documentation or configuration files
rg -i "fraxtal|frx" --type ts -A 5 -B 5

Length of output: 6350


17-20: Verify network endpoints and identifiers

Please verify:

  1. The RPC endpoint availability and reliability
  2. The Coingecko platform ID and integration
✅ Verification successful

Let me gather more information about the Coingecko platform definitions to better understand the integration.


Network configuration appears to be properly integrated

The verification shows that:

  1. The RPC endpoint is consistently referenced and aligns with the official Fraxtal network
  2. The Coingecko platform ID "fraxtal" is properly defined in the CoingeckoPlatform enum
  3. The network configuration is complete with proper integration into activity handlers and network indexes
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for Coingecko platform definitions
rg "CoingeckoPlatform\.Fraxtal" --type ts

# Check for other references to the RPC endpoint
rg "rpc\.frax\.com" --type ts

Length of output: 279


Script:

#!/bin/bash
# Check CoingeckoPlatform enum definition
ast-grep --pattern 'enum CoingeckoPlatform {
  $$$
}'

# Check for any other Fraxtal-related configurations
rg -i "fraxtal" --type ts -A 2 -B 2

Length of output: 7245

packages/types/src/networks.ts (2)

97-98: LGTM! Network names follow established conventions.

The additions of Bitrock and Fraxtal networks follow the existing naming pattern for Ethereum L2/sidechain networks using lowercase identifiers.


155-156: Verify Coingecko platform identifiers.

While the platform identifiers follow the naming convention, we should verify that these match Coingecko's API expectations to ensure proper price data integration.

Let's verify the platform identifiers:

✅ Verification successful

Platform identifiers match Coingecko's API expectations

Both "bitrock" and "fraxtal" are valid platform identifiers in Coingecko's API, with matching IDs and proper chain identifiers (Bitrock: 7171, Fraxtal: 252).

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify if the platform identifiers exist on Coingecko
# and match their API expectations

# Check if the platforms exist in Coingecko's API
for platform in "bitrock" "fraxtal"; do
  echo "Checking $platform..."
  curl -s "https://api.coingecko.com/api/v3/asset_platforms" | jq ".[] | select(.id==\"$platform\")"
done

Length of output: 1280

packages/extension/src/providers/ethereum/networks/index.ts (1)

62-63: Verify the network configuration modules

The imports follow the consistent pattern. Let's verify the existence and structure of the imported network configuration files.

✅ Verification successful

Network configuration modules are properly structured

Both imported modules exist and follow the correct network configuration pattern:

  • Both export an EvmNetwork instance with proper configuration
  • Both include required network parameters (chainID, nodes, explorers)
  • Both follow the consistent structure used across other network configurations
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence and structure of the new network configuration files

# Check if the files exist
echo "Checking for network configuration files..."
fd "bitrock.ts|fraxtal.ts" --type f

# Verify they export EvmNetwork configurations
echo "Checking network configurations..."
rg -A 10 "export default.*EvmNetwork" "bitrock.ts" "fraxtal.ts" || echo "Files not found or pattern not matched"

Length of output: 588


Script:

#!/bin/bash
# Let's check the content of these files with their full paths
echo "Checking network configurations with full paths..."
rg -A 10 "export default.*EvmNetwork" "packages/extension/src/providers/ethereum/networks/bitrock.ts" "packages/extension/src/providers/ethereum/networks/fraxtal.ts"

Length of output: 274


Script:

#!/bin/bash
# Let's examine the actual content of these files
echo "Content of bitrock.ts:"
cat packages/extension/src/providers/ethereum/networks/bitrock.ts

echo -e "\nContent of fraxtal.ts:"
cat packages/extension/src/providers/ethereum/networks/fraxtal.ts

Length of output: 1978

packages/extension/src/providers/ethereum/libs/activity-handlers/providers/etherscan/configs.ts (1)

71-71: Verify the Fraxtal block explorer API endpoint.

The endpoint follows the correct format, but as Fraxtal is a new network, we should verify:

  1. The API endpoint is publicly accessible
  2. The API follows the Etherscan-compatible interface
README.md (1)

35-109: Verify the chains list is properly alphabetized

Please verify that all entries are in alphabetical order. For example:

  • "Sepolia" appears after "Shiden EVM" but should be before "Shibarium"
🧰 Tools
🪛 LanguageTool

[duplication] ~39-~39: Possible typo: you repeated a word
Context: ... Bitcoin - Solana - Acala - Amplitude - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Au...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~42-~42: Possible typo: you repeated a word
Context: ... - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Aurora - Avalanche - Base - Bifro...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~47-~47: Possible typo: you repeated a word
Context: ...Astar EVM - Aurora - Avalanche - Base - Bifrost - Bifrost (Kusama) - Binance Smart Chain - Bitcoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~58-~58: Possible typo: you repeated a word
Context: ...net - Canto - Celo - Degen - Dogecoin - Edgeware - Edgeware EVM - Ethereum Classic - Fantom - Forma...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~69-~69: Possible typo: you repeated a word
Context: ... Ham Chain - Immutable zkEVM - Kadena - Karura - Karura EVM - Klaytn - Kusama - Linea - Litecoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~87-~87: Possible typo: you repeated a word
Context: ... - Palm Network - Pendulum - Polkadot - Polygon - Polygon zkEVM - Proof of Play Apex - Puppy Net ...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~98-~98: Possible typo: you repeated a word
Context: ...ck - Sanko Chain - Scroll - Shibarium - Shiden - Shiden EVM - Sepolia - Syscoin - Telos EVM - U...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~108-~108: Possible typo: you repeated a word
Context: ...Network - Viction - Westend - ZChains - zkSync - zkSync Goerli - More coming soon! Looking to ...

(ENGLISH_WORD_REPEAT_RULE)

README.md Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
README.md (1)

35-110: Maintain alphabetical ordering of networks

Some networks are not in alphabetical order, which affects readability. Please reorder the following:

  • Move "Bitrock" before "Bitcoin Testnet"
  • Move "Sepolia" before "Shibarium"
🧰 Tools
🪛 LanguageTool

[duplication] ~39-~39: Possible typo: you repeated a word
Context: ... Bitcoin - Solana - Acala - Amplitude - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Au...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~42-~42: Possible typo: you repeated a word
Context: ... - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Aurora - Avalanche - Base - Bifro...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~47-~47: Possible typo: you repeated a word
Context: ...Astar EVM - Aurora - Avalanche - Base - Bifrost - Bifrost (Kusama) - Binance Smart Chain - Bitcoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~58-~58: Possible typo: you repeated a word
Context: ...net - Canto - Celo - Degen - Dogecoin - Edgeware - Edgeware EVM - Ethereum Classic - Fantom - Forma...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~70-~70: Possible typo: you repeated a word
Context: ... Ham Chain - Immutable zkEVM - Kadena - Karura - Karura EVM - Klaytn - Kusama - Linea - Litecoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~88-~88: Possible typo: you repeated a word
Context: ... - Palm Network - Pendulum - Polkadot - Polygon - Polygon zkEVM - Proof of Play Apex - Puppy Net ...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~99-~99: Possible typo: you repeated a word
Context: ...ck - Sanko Chain - Scroll - Shibarium - Shiden - Shiden EVM - Sepolia - Syscoin - Telos EVM - U...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~109-~109: Possible typo: you repeated a word
Context: ...Network - Viction - Westend - ZChains - zkSync - zkSync Goerli - More coming soon! Looking to ...

(ENGLISH_WORD_REPEAT_RULE)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e2d8cb1 and cf62e30.

📒 Files selected for processing (2)
  • README.md (1 hunks)
  • packages/extension/src/providers/ethereum/networks/bitrock.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/extension/src/providers/ethereum/networks/bitrock.ts
🧰 Additional context used
🪛 LanguageTool
README.md

[duplication] ~39-~39: Possible typo: you repeated a word
Context: ... Bitcoin - Solana - Acala - Amplitude - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Au...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~42-~42: Possible typo: you repeated a word
Context: ... - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Aurora - Avalanche - Base - Bifro...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~47-~47: Possible typo: you repeated a word
Context: ...Astar EVM - Aurora - Avalanche - Base - Bifrost - Bifrost (Kusama) - Binance Smart Chain - Bitcoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~58-~58: Possible typo: you repeated a word
Context: ...net - Canto - Celo - Degen - Dogecoin - Edgeware - Edgeware EVM - Ethereum Classic - Fantom - Forma...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~70-~70: Possible typo: you repeated a word
Context: ... Ham Chain - Immutable zkEVM - Kadena - Karura - Karura EVM - Klaytn - Kusama - Linea - Litecoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~88-~88: Possible typo: you repeated a word
Context: ... - Palm Network - Pendulum - Polkadot - Polygon - Polygon zkEVM - Proof of Play Apex - Puppy Net ...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~99-~99: Possible typo: you repeated a word
Context: ...ck - Sanko Chain - Scroll - Shibarium - Shiden - Shiden EVM - Sepolia - Syscoin - Telos EVM - U...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~109-~109: Possible typo: you repeated a word
Context: ...Network - Viction - Westend - ZChains - zkSync - zkSync Goerli - More coming soon! Looking to ...

(ENGLISH_WORD_REPEAT_RULE)

🔇 Additional comments (2)
README.md (2)

63-63: LGTM: Fraxtal network added as requested

The Fraxtal network has been successfully added to the supported chains list, addressing the previous review comment.


35-110: Verify official network names and branding

Please verify that the network names match their official branding and documentation. For example:

  • "Binance Smart Chain" - verify if it should be "BNB Smart Chain"
  • "Bitcoin Testnet" - verify if it should be more specific (e.g., "Bitcoin Testnet (Signet)")
🧰 Tools
🪛 LanguageTool

[duplication] ~39-~39: Possible typo: you repeated a word
Context: ... Bitcoin - Solana - Acala - Amplitude - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Au...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~42-~42: Possible typo: you repeated a word
Context: ... - Arbitrum - Arbitrum Nova - Arthera - Astar - Astar EVM - Aurora - Avalanche - Base - Bifro...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~47-~47: Possible typo: you repeated a word
Context: ...Astar EVM - Aurora - Avalanche - Base - Bifrost - Bifrost (Kusama) - Binance Smart Chain - Bitcoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~58-~58: Possible typo: you repeated a word
Context: ...net - Canto - Celo - Degen - Dogecoin - Edgeware - Edgeware EVM - Ethereum Classic - Fantom - Forma...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~70-~70: Possible typo: you repeated a word
Context: ... Ham Chain - Immutable zkEVM - Kadena - Karura - Karura EVM - Klaytn - Kusama - Linea - Litecoi...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~88-~88: Possible typo: you repeated a word
Context: ... - Palm Network - Pendulum - Polkadot - Polygon - Polygon zkEVM - Proof of Play Apex - Puppy Net ...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~99-~99: Possible typo: you repeated a word
Context: ...ck - Sanko Chain - Scroll - Shibarium - Shiden - Shiden EVM - Sepolia - Syscoin - Telos EVM - U...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~109-~109: Possible typo: you repeated a word
Context: ...Network - Viction - Westend - ZChains - zkSync - zkSync Goerli - More coming soon! Looking to ...

(ENGLISH_WORD_REPEAT_RULE)

@kvhnuke kvhnuke merged commit ba340a8 into develop Nov 26, 2024
3 of 4 checks passed
@kvhnuke kvhnuke deleted the devop/new-networks branch November 26, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants