Merge pull request #281 from ennvina/feature/242-paladin-cata

Paladin (Cata) + bug fixes

SpellActivationOverlay.lua

@@ -164,7 +164,9 @@ function SpellActivationOverlay_OnEvent(self, event, ...)
 		-- end
 	elseif ( event == "SPELL_ACTIVATION_OVERLAY_HIDE" ) then
 		local spellID = ...;
-		SAO:Debug(Module, "Received native SPELL_ACTIVATION_OVERLAY_HIDE with spell ID "..tostring(spellID));
+		if spellID then
+			SAO:Debug(Module, "Received native SPELL_ACTIVATION_OVERLAY_HIDE with spell ID "..tostring(spellID));
+		end
 		-- if spellID then
 		-- 	SpellActivationOverlay_HideOverlays(self, spellID);
 		-- else

SpellActivationOverlay.toc

@@ -1,8 +1,8 @@
-## Interface: 30403
-## Title: |TInterface/Icons/Spell_Frost_Stun:16:16:0:0:512:512:64:448:64:448|t SpellActivationOverlay |cffa2f3ff1.4.0|r
+## Interface: 40400
+## Title: |TInterface/Icons/Spell_Frost_Stun:16:16:0:0:512:512:64:448:64:448|t SpellActivationOverlay |cffa2f3ff1.4.1|r
 ## Notes: Mimic Spell Activation Overlays from Modern World of Warcraft
 ## Author: Vinny/Ennvina
-## Version: 1.4.0
+## Version: 1.4.1
 ## SavedVariables: SpellActivationOverlayDB
 
 # SpellActivationOverlay.lua, SpellActivationOverlay.xml and all textures were created by Blizzard Entertainment, Inc.

_script/package.sh

@@ -35,6 +35,17 @@ mkproject() {
     echo
 }
 
+# Remove copyright of given expansions because the addon does not embed texture for these expansions
+# Expansion anmes are case sensitive, and must match one of the copyrights includes in TOC file
+# $1+ = expansions
+prunecopyright() {
+    for expansion in "$@"
+    do
+        grep -q "${expansion}" SpellActivationOverlay/SpellActivationOverlay.toc || bye "Cannot find copyright of expansion ${expansion} in TOC file"
+        sed -i "/${expansion}/,+2d" SpellActivationOverlay/SpellActivationOverlay.toc || bye "Cannot remove copyright of expansion ${expansion} from TOC file"
+    done
+}
+
 # Find texture names which file data ID is lesser or equal to a specific threshold
 # Such textures are supposed to be already embedded in the game files
 # $1 = threshold up until textures are supposed to be embedded, and can be pruned
@@ -177,6 +188,8 @@ cdup
 CATA_BUILD_VERSION=40400
 mkproject cata $CATA_BUILD_VERSION
 
+prunecopyright Cataclysm
+
 TEXTURES_NOT_FOR_CATA=(
 tooth_and_claw
 monk_serpent

changelog.md

@@ -1,5 +1,50 @@
 ## SpellActivationOverlay Changelog
 
+#### v1.4.1 (2024-05-10)
+
+New effects:
+- New SAO: Paladin's Daybreak (Cataclysm)
+- New SAO: Paladin's Divine Purpose (Cataclysm)
+- New SAO: Paladin's Grand Crusader (Cataclysm)
+- New GAB: Paladin's Inquisition, during Divine Purpose (Cataclysm)
+- New GAB: Paladin's Templar's Verdict, during Divine Purpose (Cataclysm)
+- New GAB: Paladin's Word of Glory, during Divine Purpose (Cataclysm)
+- New GAB: Paladin's Zealotry, during Divine Purpose (Cataclysm)
+- New GAB: Paladin's Holy Light, during Crusade (Cataclysm)
+- New GAB: Paladin's Holy Shock, during Daybreak (Cataclysm)
+- New GAB: Paladin's Avenger's Shield, during Grand Crusader (Cataclysm)
+
+Bug Fixes
+- Some effects triggered immediately upon login would not glow their buttons
+
+Glowing Buttons would only glow rank 1 of the following spells and abilities:
+- Death Knight's Frost Strike (Wrath)
+- Death Knight's Howling Blast (Wrath)
+- Death Knight's Icy Touch (Wrath)
+- Druid's Cyclone (Wrath)
+- Druid's Entangling Roots (Wrath)
+- Druid's Healing Touch (Season of Discovery, Wrath)
+- Druid's Hibernate (Wrath)
+- Druid's Nourish (Wrath)
+- Druid's Rebirth (Wrath)
+- Druid's Regrowth (Wrath)
+- Druid's Starfire (Wrath)
+- Druid's Wrath (Wrath)
+- Hunter's Aimed Shot (Wrath)
+- Hunter's Arcane Shot (Wrath)
+- Hunter's Counterattack (Era, TBC, Wrath)
+- Hunter's Explosive Shot (Wrath)
+- Hunter's Kill Shot (Wrath)
+- Hunter's Mongoose Bite (Era, TBC)
+- Shaman's Chain Heal (Season of Discovery, Wrath)
+- Shaman's Chain Lightning (Season of Discovery, Wrath)
+- Shaman's Lesser Healing Wave (Season of Discovery, Wrath)
+- Shaman's Lightning Bolt (Season of Discovery, Wrath)
+- Shaman's Healing Wave (Season of Discovery, Wrath)
+- Warlock's Incinerate (TBC, Wrath)
+- Warlock's Shadow Bolt (Era, TBC, Wrath)
+- Warlock's Soul Fire (Wrath)
+
 #### v1.4.0 (2024-05-06)
 
 Shout-out to fellow developers Amanthuul and espionn. Thanks!