Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 [security] Update pug 3.0.0 → 3.0.3 (patch) #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🚨 [security] Update pug 3.0.0 → 3.0.3 (patch) #127

wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 26, 2024 •
edited
Loading

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ pug (3.0.0 → 3.0.3) · Repo · Changelog

Security Advisories 🚨

🚨 Pug allows JavaScript code execution if an application accepts untrusted input

Pug through 3.0.2 allows JavaScript code execution if an application accepts untrusted input for the name option of the compileClient, compileFileClient, or compileClientWithDependenciesTracked function. NOTE: these functions are for compiling Pug templates into JavaScript, and there would typically be no reason to allow untrusted callers.

🚨 Remote code execution via the `pretty` option.

Impact

If a remote attacker was able to control the pretty option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.

Patches

Upgrade to [email protected] or [email protected] or [email protected], which correctly sanitise the parameter.

Workarounds

If there is no way for un-trusted input to be passed to pug as the pretty option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.

References

Original report: #3312

For more information

If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy

↗️ @​babel/parser (indirect, 7.12.3 → 7.24.6) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by 44 commits:

↗️ @​babel/types (indirect, 7.12.1 → 7.24.6) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by 44 commits:

↗️ has-symbols (indirect, 1.0.1 → 1.0.3) · Repo · Changelog

Release Notes

1.0.3 (from changelog)

Commits

  • [actions] use node/install instead of node/run; use codecov action 518b28f
  • [meta] add bugs and homepage fields; reorder package.json c480b13
  • [actions] reuse common workflows 01d0ee0
  • [actions] update codecov uploader 6424ebe
  • [Dev Deps] update eslint, @ljharb/eslint-config, aud, auto-changelog, tape dfa7e7f
  • [Dev Deps] update eslint, @ljharb/eslint-config, safe-publish-latest, tape 0c8d436
  • [Dev Deps] update eslint, @ljharb/eslint-config, aud, tape 9026554
  • [readme] add actions and codecov badges eaa9682
  • [Dev Deps] update eslint, tape bc7a3ba
  • [Dev Deps] update eslint, auto-changelog 0ace00a
  • [meta] use prepublishOnly script for npm 7+ 093f72b
  • [Tests] test on all 16 minors 9b80d3d

1.0.2 (from changelog)

Fixed

  • [Fix] use a universal way to get the original Symbol #11

Commits

  • [Tests] migrate tests to Github Actions 90ae798
  • [meta] do not publish github action workflow files 29e60a1
  • [Tests] run nyc on all tests 8476b91
  • [readme] fix repo URLs, remove defunct badges 126288e
  • [Dev Deps] update eslint, @ljharb/eslint-config, aud, auto-changelog, core-js, get-own-property-symbols d84bdfa
  • [Tests] fix linting errors 0df3070
  • [actions] add "Allow Edits" workflow 1e6bc29
  • [Dev Deps] update eslint, @ljharb/eslint-config, tape 36cea2a
  • [Dev Deps] update eslint, @ljharb/eslint-config, aud, tape 1278338
  • [Dev Deps] update eslint, @ljharb/eslint-config, aud, tape 1493254
  • [Dev Deps] update eslint, @ljharb/eslint-config, core-js b090bf2
  • [actions] switch Automatic Rebase workflow to pull_request_target event 4addb7a
  • [Dev Deps] update auto-changelog, tape 81d0baf
  • [Dev Deps] update auto-changelog; add aud 1a4e561
  • [readme] remove unused testling URLs 3000941
  • [Tests] only audit prod deps 692e974
  • [Dev Deps] update @ljharb/eslint-config 51c946c

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 32 commits:

↗️ is-regex (indirect, 1.1.1 → 1.1.4) · Repo · Changelog

Release Notes

1.1.4 (from changelog)

Commits

  • [Dev Deps] update auto-changelog, core-js, eslint, tape 4b17cad
  • [Refactor] use has-tostringtag to behave correctly in the presence of symbol shams 2dad4af

1.1.3 (from changelog)

Commits

  • [actions] use node/install instead of node/run; use codecov action c681ab9
  • [Fix] do not use Object.prototype.toString when Symbol.toStringTag is shammed ca019fd
  • [Dev Deps] update eslint, @ljharb/eslint-config, aud, tape 605a66f
  • [readme] add actions and codecov badges 8d7c6f0
  • [meta] use prepublishOnly script for npm 7+ 8e50e91
  • [Deps] update has-symbols 4742c81

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 22 commits:

↗️ pug-code-gen (indirect, 3.0.1 → 3.0.3) · Repo · Changelog

Security Advisories 🚨

🚨 Pug allows JavaScript code execution if an application accepts untrusted input

Pug through 3.0.2 allows JavaScript code execution if an application accepts untrusted input for the name option of the compileClient, compileFileClient, or compileClientWithDependenciesTracked function. NOTE: these functions are for compiling Pug templates into JavaScript, and there would typically be no reason to allow untrusted callers.

🚨 Remote code execution via the `pretty` option.

Impact

If a remote attacker was able to control the pretty option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.

Patches

Upgrade to [email protected] or [email protected] or [email protected], which correctly sanitise the parameter.

Workarounds

If there is no way for un-trusted input to be passed to pug as the pretty option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.

References

Original report: #3312

For more information

If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy

🆕 @​babel/helper-string-parser (added, 7.24.6)

🆕 call-bind (added, 1.0.7)

🆕 define-data-property (added, 1.1.4)

🆕 es-define-property (added, 1.0.0)

🆕 es-errors (added, 1.3.0)

🆕 function-bind (added, 1.1.2)

🆕 get-intrinsic (added, 1.2.4)

🆕 gopd (added, 1.0.1)

🆕 has-property-descriptors (added, 1.0.2)

🆕 has-proto (added, 1.0.3)

🆕 has-tostringtag (added, 1.0.2)

🆕 hasown (added, 2.0.2)

🆕 set-function-length (added, 1.2.2)

🗑️ lodash (removed)

👉 No CI detected

You don't seem to have any Continuous Integration service set up!

Without a service that will test the Depfu branches and pull requests, we can't inform you if incoming updates actually work with your app. We think that this degrades the service we're trying to provide down to a point where it is more or less meaningless.

This is fine if you just want to give Depfu a quick try. If you want to really let Depfu help you keep your app up-to-date, we recommend setting up a CI system:

* [Circle CI](https://circleci.com), [Semaphore ](https://semaphoreci.com) and [Github Actions](https://docs.github.com/actions) are all excellent options. * If you use something like Jenkins, make sure that you're using the Github integration correctly so that it reports status data back to Github. * If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with `depfu/`.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 26, 2024
@depfu depfu bot mentioned this pull request May 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants