Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stickyheaders composer reorg #14

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Stickyheaders composer reorg #14

wants to merge 9 commits into from

Conversation

hexmode
Copy link

@hexmode hexmode commented Jul 19, 2018

This is the sticky headers, source code reorg, etc, that I sent a pull request for before.

Moved this work onto a separate branch till it gets merged.

Mark Hershberger and others added 8 commits June 3, 2016 20:32
Add ability to add a header just after <body>
dc8fa78 
Also create shouldUse function that encapsulates the test to display this.
Add new extension loader
234fd9f
add possibility for [[MediaWiki:hf-top-header]]
d0f0693
@hexmode
Different headers for different namespaces
9185c98 
w/s, too
@hexmode
Add sticky headers and overhaul layout
76ce3d7 
* Working on FF and Chrome.  IE tbd.
* Add license
* Add informaton to README
* Namespace-ify
* remove old shim loader for old MediaWiki
* Reorg files
* Update composer
@hexmode
default to hf-top-header or hf-sticky-header if no namespace version …
06616e2 
…is given
@hexmode
Get rid of top-header that depends on a core modification
437dbb3
@hexmode
Make sticky headers optional
2604564
@jamesmontalvo3
Copy link
Contributor

What does "Sticky Headers" mean? What does this change actually do?

@hexmode
Copy link
Author

hexmode commented Jul 20, 2018 •
edited
Loading

When $wgUseStickyHeaders = true (the default) js and css is added to what is served so that the older style sticky css objects are used when so that when you scroll up the header sticks around. See this demo with the newer "position: sticky" css to see an example of what this looks like (kind of). Here's a pure-css demonstration of the older way.

CSS's position: sticky is probably too new to use.

@jamesmontalvo3
Copy link
Contributor

Seems like sticky shouldn't be the default. People shouldn't have to change configuration just because they upgraded, unless there's good reason. Right?

@hexmode
Copy link
Author

hexmode commented Jul 20, 2018

Right, shouldn't be the default.

@jamesmontalvo3
Copy link
Contributor

Main NS footer not rendering HTML. See example below, footer indicated by red box.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hexmode @jamesmontalvo3